* [PATCH] ox-html.el: add exporting of priority
@ 2015-01-09 3:23 Zane D. Purvis
2015-01-09 8:20 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Zane D. Purvis @ 2015-01-09 3:23 UTC (permalink / raw)
To: emacs-orgmode
* list/ox-html.el (org-html--priority): new function
(org-html-format-headline-default-function): call `org-html--priority'
(org-html-style-default): add `.priority'
HTML export previously did not support exporting of priority simply by setting
`org-export-with-priority' to `t'.
TINYCHANGE
---
lisp/ox-html.el | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 3c3b444..1d1aa57 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -278,6 +278,7 @@ for the JavaScript code in this tag.
.done { color: green; }
.tag { background-color: #eee; font-family: monospace;
padding: 2px; font-size: 80%; font-weight: normal; }
+ .priority { font-family: monospace; color: orange; }
.timestamp { color: #bebebe; }
.timestamp-kwd { color: #5f9ea0; }
.right { margin-left: auto; margin-right: 0px; text-align: right; }
@@ -1885,6 +1886,16 @@ INFO is a plist used as a communication channel."
(org-html-fix-class-name todo)
todo)))
+;;;; Priority
+
+(defun org-html--priority (priority info)
+ "Format a priority into HTML.
+PRIORITY is the character code of the priority or nil.
+INFO is a plist containing export options."
+ (when priority
+ (format "<span class=\"priority\">[%s]</span>"
+ (byte-to-string priority))))
+
;;;; Tags
(defun org-html--tags (tags info)
@@ -2396,8 +2407,9 @@ holding contextual information."
"Default format function for a headline.
See `org-html-format-headline-function' for details."
(let ((todo (org-html--todo todo info))
+ (priority (org-html--priority priority info))
(tags (org-html--tags tags info)))
- (concat todo (and todo " ") text (and tags "   ") tags)))
+ (concat todo (and todo " ") priority (and priority " ") text (and
tags "   ") tags)))
(defun org-html--container (headline info)
(or (org-element-property :HTML_CONTAINER headline)
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-html.el: add exporting of priority
2015-01-09 3:23 [PATCH] ox-html.el: add " Zane D. Purvis
@ 2015-01-09 8:20 ` Nicolas Goaziou
2015-01-09 14:30 ` Zane D. Purvis
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2015-01-09 8:20 UTC (permalink / raw)
To: Zane D. Purvis; +Cc: emacs-orgmode
Hello,
"Zane D. Purvis" <zane.purvis@gmail.com> writes:
Thanks for the patch.
The summary line should be capitalized, i.e.,
ox-html: Add exporting of priority
> * list/ox-html.el (org-html--priority): new function
Capitalize, too.
> (org-html-format-headline-default-function): call `org-html--priority'
Ditto.
> (org-html-style-default): add `.priority'
Ditto.
> +(defun org-html--priority (priority info)
> + "Format a priority into HTML.
> +PRIORITY is the character code of the priority or nil.
> +INFO is a plist containing export options."
> + (when priority
> + (format "<span class=\"priority\">[%s]</span>"
> + (byte-to-string priority))))
Shorter:
(and priority (format "<span class=\"priority\">[%c]</span>" priority))
Could you fix these issues before I apply your patch?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-html.el: add exporting of priority
2015-01-09 8:20 ` Nicolas Goaziou
@ 2015-01-09 14:30 ` Zane D. Purvis
0 siblings, 0 replies; 5+ messages in thread
From: Zane D. Purvis @ 2015-01-09 14:30 UTC (permalink / raw)
To: Zane D. Purvis, emacs-orgmode
Sure thing. Expect a new patch momentarily. Thanks.
On Fri, Jan 9, 2015 at 3:20 AM, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> Hello,
>
> "Zane D. Purvis" <zane.purvis@gmail.com> writes:
>
> Thanks for the patch.
>
> The summary line should be capitalized, i.e.,
>
> ox-html: Add exporting of priority
>
>> * list/ox-html.el (org-html--priority): new function
>
> Capitalize, too.
>
>> (org-html-format-headline-default-function): call `org-html--priority'
>
> Ditto.
>
>> (org-html-style-default): add `.priority'
>
> Ditto.
>
>> +(defun org-html--priority (priority info)
>> + "Format a priority into HTML.
>> +PRIORITY is the character code of the priority or nil.
>> +INFO is a plist containing export options."
>> + (when priority
>> + (format "<span class=\"priority\">[%s]</span>"
>> + (byte-to-string priority))))
>
> Shorter:
>
> (and priority (format "<span class=\"priority\">[%c]</span>" priority))
>
> Could you fix these issues before I apply your patch?
>
>
> Regards,
>
> --
> Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ox-html.el: Add exporting of priority
@ 2015-01-09 15:43 Zane D. Purvis
2015-01-10 9:29 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Zane D. Purvis @ 2015-01-09 15:43 UTC (permalink / raw)
To: emacs-orgmode
* list/ox-html.el (org-html--priority): New function.
(org-html-format-headline-default-function): Call `org-html--priority'.
(org-html-style-default): Add `.priority'.
HTML export previously did not support exporting of priority simply by setting
`org-export-with-priority' to `t'.
TINYCHANGE
---
lisp/ox-html.el | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lisp/ox-html.el b/lisp/ox-html.el
index 3c3b444..a1c33ac 100644
--- a/lisp/ox-html.el
+++ b/lisp/ox-html.el
@@ -278,6 +278,7 @@ defconst org-html-style-default
.done { color: green; }
.tag { background-color: #eee; font-family: monospace;
padding: 2px; font-size: 80%; font-weight: normal; }
+ .priority { font-family: monospace; color: orange; }
.timestamp { color: #bebebe; }
.timestamp-kwd { color: #5f9ea0; }
.right { margin-left: auto; margin-right: 0px; text-align: right; }
@@ -1885,6 +1886,14 @@ defun org-html--todo (todo info)
(org-html-fix-class-name todo)
todo)))
+;;;; Priority
+
+(defun org-html--priority (priority info)
+ "Format a priority into HTML.
+PRIORITY is the character code of the priority or nil.
+INFO is a plist containing export options."
+ (and priority (format "<span class=\"priority\">[%c]</span>" priority)))
+
;;;; Tags
(defun org-html--tags (tags info)
@@ -2396,8 +2405,9 @@ defun org-html-format-headline-default-function
"Default format function for a headline.
See `org-html-format-headline-function' for details."
(let ((todo (org-html--todo todo info))
+ (priority (org-html--priority priority info))
(tags (org-html--tags tags info)))
- (concat todo (and todo " ") text (and tags "   ") tags)))
+ (concat todo (and todo " ") priority (and priority " ") text (and
tags "   ") tags)))
(defun org-html--container (headline info)
(or (org-element-property :HTML_CONTAINER headline)
--
1.9.2.msysgit.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ox-html.el: Add exporting of priority
2015-01-09 15:43 [PATCH] ox-html.el: Add exporting of priority Zane D. Purvis
@ 2015-01-10 9:29 ` Nicolas Goaziou
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2015-01-10 9:29 UTC (permalink / raw)
To: Zane D. Purvis; +Cc: emacs-orgmode
Hello,
"Zane D. Purvis" <zane.purvis@gmail.com> writes:
> * list/ox-html.el (org-html--priority): New function.
> (org-html-format-headline-default-function): Call `org-html--priority'.
> (org-html-style-default): Add `.priority'.
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-10 9:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-09 15:43 [PATCH] ox-html.el: Add exporting of priority Zane D. Purvis
2015-01-10 9:29 ` Nicolas Goaziou
-- strict thread matches above, loose matches on Subject: below --
2015-01-09 3:23 [PATCH] ox-html.el: add " Zane D. Purvis
2015-01-09 8:20 ` Nicolas Goaziou
2015-01-09 14:30 ` Zane D. Purvis
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).