From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch, koma-letter] Change of subject behavior Date: Wed, 18 Mar 2015 12:41:17 +0100 Message-ID: <877fue1qjm.fsf@nicolasgoaziou.fr> References: <87d247h6eo.fsf@gmx.us> <87wq2f1gqz.fsf@nicolasgoaziou.fr> <87mw3bdyv4.fsf@gmx.us> <87bnjr1au0.fsf@nicolasgoaziou.fr> <877fufdwf0.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYCKY-0004wx-D1 for emacs-orgmode@gnu.org; Wed, 18 Mar 2015 07:40:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYCKT-0006gj-M9 for emacs-orgmode@gnu.org; Wed, 18 Mar 2015 07:40:10 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:33819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYCKT-0006ej-GH for emacs-orgmode@gnu.org; Wed, 18 Mar 2015 07:40:05 -0400 In-Reply-To: <877fufdwf0.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 18 Mar 2015 00:41:23 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: >>> + (:with-headline-opening nil nil >>> org-koma-letter-headline-is-opening-maybe) >> >> I don't think this line is required. > > It feels more consistent to provide the check through the definition, but > I'm not willing to pick a fight over this so it's back to just checking > the variable. Of course, you're right. It is way better to add it as an option, since you can override variable value during publishing. You can irrevocably ignore my comment. > I have only tested the patch briefly as I need to actually produce a > letter. But for the letter I'm writing export works fine. You sent a wrong patch. Regards,