From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: replace letf with cl-letf in org-mime
Date: Wed, 01 Apr 2015 21:46:01 +0200
Message-ID: <877ftvy6me.fsf@nicolasgoaziou.fr>
References: <87wq29m8zm.fsf@ericabrahamsen.net>
	<87iodt2k3i.fsf@nicolasgoaziou.fr> <87619iopdj.fsf@ericabrahamsen.net>
	<87zj6txxbw.fsf@nicolasgoaziou.fr> <87384k619d.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YdOZE-0007zy-Ll
	for emacs-orgmode@gnu.org; Wed, 01 Apr 2015 15:44:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YdOZB-0002td-Vr
	for emacs-orgmode@gnu.org; Wed, 01 Apr 2015 15:44:48 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:57081)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YdOZB-0002t7-Pd
	for emacs-orgmode@gnu.org; Wed, 01 Apr 2015 15:44:45 -0400
In-Reply-To: <87384k619d.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Wed, 01 Apr 2015 10:17:02 +0800")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> If I remove the two `eval's and treat "hook" like a normal variable, the
> call to `length' fails with:
>
> Wrong type argument: sequencep, org-mime-pre-org-hook
>
> So apparently `length' is seeing the symbol name, and not the symbol
> value.

Indeed.

> I tried changing the `let' to look like:
>
> (let ((hook (symbol-value (intern (....

What about (length (symbol-value hook)) instead?

> Here's a fixed version of the previous patch.

Thank you. Applied.

> I suppose I could also alter the "bhook" thing to use `symbol-value'
> instead of `eval', but that doesn't seem to be a net gain.

IMO, anything is a net gain compared to using `eval'.


Regards,