From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rasmus <rasmus@gmx.us>
Subject: Re: [bug] org-cycle changed behavior in orgstruct-mode
Date: Sat, 29 Aug 2015 23:12:51 +0200
Message-ID: <877fodpzn0.fsf@gmx.us>
References: <87fv3q2lxs.fsf@gmx.us> <878u9ic8sv.fsf@nicolasgoaziou.fr>
	<87zj1y0zst.fsf@gmx.us> <87614l95p7.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ZVnQu-0004Ft-Su
	for emacs-orgmode@gnu.org; Sat, 29 Aug 2015 17:13:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ZVnQr-0005G6-N2
	for emacs-orgmode@gnu.org; Sat, 29 Aug 2015 17:13:04 -0400
Received: from plane.gmane.org ([80.91.229.3]:44724)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ZVnQr-0005Fu-GY
	for emacs-orgmode@gnu.org; Sat, 29 Aug 2015 17:13:01 -0400
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <geo-emacs-orgmode@m.gmane.org>) id 1ZVnQo-0008DK-Cx
	for emacs-orgmode@gnu.org; Sat, 29 Aug 2015 23:12:58 +0200
Received: from 46.166.188.219 ([46.166.188.219])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 29 Aug 2015 23:12:58 +0200
Received: from rasmus by 46.166.188.219 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <emacs-orgmode@gnu.org>; Sat, 29 Aug 2015 23:12:58 +0200
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: emacs-orgmode@gnu.org

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Rasmus <rasmus@gmx.us> writes:
>
>> I tried to recompile with that line commented out but it doesn't make a
>> difference.  I also tried to remove that defun from orgstruct-setup, but
>> that also didn't make change anything.
>
> What if you replace the defun with `show-children' in `orgstruct-setup'
> instead of simply removing the line? You may want to still comment out
> the line above though.

I tried to add show-children, and NOT have org-show-children in the setup
but alas it doesn't change the situation.  But anyway it's called through
`org-cycle', in my use-case at least.  This in turn rely on at least
org-cycle-internal-local which in turn uses org-show-children.

So maybe the easiest way to "fix" this is to advice orgstruct to redirect
call?  Maybe add-function :around... We can rely on nadvice in master,
right?

Rasmus

-- 
Need more coffee. . .