From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-player and switch to lexical binding in org.el
Date: Sun, 31 Jan 2016 00:30:39 +0100
Message-ID: <877fiqhcgw.fsf@nicolasgoaziou.fr>
References: <CALn3zoh+ACSU09eRurfwKjmCnw7i-_0KX7tA2jWqtu=vvQepLQ@mail.gmail.com>
	<877fj8j5wx.fsf@nicolasgoaziou.fr>
	<CALn3zogtPi0rzSfvEh67e7tzJ-KUDJZmckv16j+MNkx2Nhj7yw@mail.gmail.com>
	<87oac4a4v2.fsf@nicolasgoaziou.fr>
	<CALn3zojoY7JEa3COgC5um-=gcrA5=nSi8GNmq9_1B_P+jz32uA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aPewc-0005Bh-1H
	for emacs-orgmode@gnu.org; Sat, 30 Jan 2016 18:28:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aPewa-0000Yx-Iv
	for emacs-orgmode@gnu.org; Sat, 30 Jan 2016 18:28:41 -0500
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:47147)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aPewa-0000Yt-Bj
	for emacs-orgmode@gnu.org; Sat, 30 Jan 2016 18:28:40 -0500
In-Reply-To: <CALn3zojoY7JEa3COgC5um-=gcrA5=nSi8GNmq9_1B_P+jz32uA@mail.gmail.com>
	(Michael Brand's message of "Fri, 29 Jan 2016 21:39:04 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Michael Brand <michael.ch.brand@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>, Paul Sexton <psexton.2a@gmail.com>

Hello,

Michael Brand <michael.ch.brand@gmail.com> writes:

> Only slowly I begin to get it partially. My observation is that if the
> current `org-open-file' would be changed to
>
>     (eval cmd
>           ;; LEXICAL argument.
>           `((file . ,(convert-standard-filename file))
>             (link . ,dlink)))

Actually, that should be (eval cmd t). Providing an alist is not
necessary here.

> to provide also the `link' symbol then a
>
>     (add-to-list 'org-file-apps
>                  (cons (concat org-player-file-extensions-regexp
>                                "::\\([0-9]+:[0-9]+\\(:[0-9]+\\)?\\)")
>                        '(org-player-play-file file (match-string 1 link))))
>
> which is simple enough for me to understand in org-player.el works.
> This situation looks favorable to me at least for a first step because
> it would mean a version of org-player.el that remains compatible with
> "any" Org before lexical binding in org.el
> (release_8.3.3-426-g1f49e9f) but would also become compatible again
> starting with one of the next commits in Org master.
>
> Do I understand correct that this would not break any backward
> compatibility with all other existing and correct use of
> `org-file-apps'?

Although it does the job, it would leave an `eval' in the code base,
which is not very pretty, and more difficult to maintain (scope is less
obvious). That's why I prefer the functions. Of course, it may not be
worth the trouble if introduced backward incompatibility is really
nasty.


Regards,

-- 
Nicolas Goaziou