From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH 2/2] org-colview.el: Add property :exclude-tags to column
 view
Date: Sat, 07 Jul 2018 09:31:15 +0200
Message-ID: <877em733jw.fsf@nicolasgoaziou.fr>
References: <87zhz46mbx.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fbhgh-0006km-I8
	for emacs-orgmode@gnu.org; Sat, 07 Jul 2018 03:31:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1fbhgc-0006UY-Jg
	for emacs-orgmode@gnu.org; Sat, 07 Jul 2018 03:31:23 -0400
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:44171)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1fbhgc-0006Tw-Dm
	for emacs-orgmode@gnu.org; Sat, 07 Jul 2018 03:31:18 -0400
In-Reply-To: <87zhz46mbx.fsf@gmail.com> (Benjamin Motz's message of "Sat, 07
	Jul 2018 00:17:22 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Benjamin Motz <benni.motz@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Benjamin Motz <benni.motz@gmail.com> writes:

> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> From 4ac32c4b24f33b841ad73c4b10158ec7a18087a9 Mon Sep 17 00:00:00 2001
> From: Benjamin Motz <benni.motz@gmail.com>
> Date: Wed, 4 Jul 2018 14:27:24 +0200
> Subject: [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view
>  table
>
> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> TINYCHANGE

It looks good. This need to be documented in the manual, though. Would you
mind adding this to your patch. 

Also, a test would be nice in "test-org-colview.el", more accurately in
`test-org-colview/dblock'. Could you add one?

> -(defun org-columns--capture-view (maxlevel match skip-empty format local)
> +(defun org-columns--capture-view (maxlevel match skip-empty exclude-tags format local)
>    "Get the column view of the current buffer.

You need to describe the new argument in the docstring.

Thank you.

Regards,

-- 
Nicolas Goaziou