emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] fix org-num-mode detect enabled already issue
@ 2019-01-05 13:43 stardiviner
  2019-01-06 23:46 ` Nicolas Goaziou
  0 siblings, 1 reply; 5+ messages in thread
From: stardiviner @ 2019-01-05 13:43 UTC (permalink / raw)
  To: org-mode


When I execute command `[M-x org-mode]` on an Org buffer which is
already have `org-num-mode` enabled. It will re-generate overlay.

Here is a quick patch:

modified   lisp/org-num.el
@@ -438,17 +438,16 @@ NUMBERING is a list of numbers."
 (define-minor-mode org-num-mode
   "Dynamic numbering of headlines in an Org buffer."
   :lighter " o#"
-  (cond
-   (org-num-mode
+  (if org-num-mode
+      (progn
+	(mapc #'delete-overlay org-num--overlays)
+	(setq org-num--overlays nil)
+	(remove-hook 'after-change-functions #'org-num--verify t))
     (unless (derived-mode-p 'org-mode)
       (user-error "Cannot activate headline numbering outside Org mode"))
     (setq org-num--numbering nil)
     (setq org-num--overlays (nreverse (org-num--number-region nil nil)))
-    (add-hook 'after-change-functions #'org-num--verify nil t))
-   (t
-    (mapc #'delete-overlay org-num--overlays)
-    (setq org-num--overlays nil)
-    (remove-hook 'after-change-functions #'org-num--verify t))))
+    (add-hook 'after-change-functions #'org-num--verify nil t)))

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fix org-num-mode detect enabled already issue
  2019-01-05 13:43 [PATCH] fix org-num-mode detect enabled already issue stardiviner
@ 2019-01-06 23:46 ` Nicolas Goaziou
  2019-01-07  1:13   ` stardiviner
  2019-01-07  6:07   ` stardiviner
  0 siblings, 2 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2019-01-06 23:46 UTC (permalink / raw)
  To: stardiviner; +Cc: org-mode

Hello,

stardiviner <numbchild@gmail.com> writes:

> When I execute command `[M-x org-mode]` on an Org buffer which is
> already have `org-num-mode` enabled. It will re-generate overlay.

I don't understand the issue you are encountering. Could you elaborate?

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fix org-num-mode detect enabled already issue
  2019-01-06 23:46 ` Nicolas Goaziou
@ 2019-01-07  1:13   ` stardiviner
  2019-01-09 22:29     ` Nicolas Goaziou
  2019-01-07  6:07   ` stardiviner
  1 sibling, 1 reply; 5+ messages in thread
From: stardiviner @ 2019-01-07  1:13 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode

[-- Attachment #1: Type: text/plain, Size: 58 bytes --]


Here is the screenshot which can demostrate this issue:


[-- Attachment #2: org-num-mode repeat after M-x org-mode.png --]
[-- Type: image/png, Size: 66680 bytes --]

[-- Attachment #3: Type: text/plain, Size: 594 bytes --]



And here is the steps to reproduce this issue:

my config:

(require 'org-num)
(setq org-num-skip-footnotes t)
(add-hook 'org-mode-hook #'org-num-mode)

1. Then open an Org file, it has `org-num-mode` enabled because upper
   config added to hook.

2. Execute command with `[M-x org-mode]` again, then it will become as
   in screenshot.

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fix org-num-mode detect enabled already issue
  2019-01-06 23:46 ` Nicolas Goaziou
  2019-01-07  1:13   ` stardiviner
@ 2019-01-07  6:07   ` stardiviner
  1 sibling, 0 replies; 5+ messages in thread
From: stardiviner @ 2019-01-07  6:07 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: org-mode


I fixed my previous patch which work in reverse direction.

modified   lisp/org-num.el
@@ -438,17 +438,16 @@ NUMBERING is a list of numbers."
 (define-minor-mode org-num-mode
   "Dynamic numbering of headlines in an Org buffer."
   :lighter " o#"
-  (cond
-   (org-num-mode
-    (unless (derived-mode-p 'org-mode)
-      (user-error "Cannot activate headline numbering outside Org mode"))
-    (setq org-num--numbering nil)
-    (setq org-num--overlays (nreverse (org-num--number-region nil nil)))
-    (add-hook 'after-change-functions #'org-num--verify nil t))
-   (t
+  (if org-num-mode
+      (progn
+	(unless (derived-mode-p 'org-mode)
+	  (user-error "Cannot activate headline numbering outside Org mode"))
+	(setq org-num--numbering nil)
+	(setq org-num--overlays (nreverse (org-num--number-region nil nil)))
+	(add-hook 'after-change-functions #'org-num--verify nil t))
     (mapc #'delete-overlay org-num--overlays)
     (setq org-num--overlays nil)
-    (remove-hook 'after-change-functions #'org-num--verify t))))
+    (remove-hook 'after-change-functions #'org-num--verify t)))
 

-- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] fix org-num-mode detect enabled already issue
  2019-01-07  1:13   ` stardiviner
@ 2019-01-09 22:29     ` Nicolas Goaziou
  0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou @ 2019-01-09 22:29 UTC (permalink / raw)
  To: stardiviner; +Cc: org-mode

Hello,

stardiviner <numbchild@gmail.com> writes:

> And here is the steps to reproduce this issue:
>
> my config:
>
> (require 'org-num)
> (setq org-num-skip-footnotes t)
> (add-hook 'org-mode-hook #'org-num-mode)
>
> 1. Then open an Org file, it has `org-num-mode` enabled because upper
>    config added to hook.
>
> 2. Execute command with `[M-x org-mode]` again, then it will become as
>    in screenshot.

OK, I see. Fixed. Thank you!

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-01-09 22:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-05 13:43 [PATCH] fix org-num-mode detect enabled already issue stardiviner
2019-01-06 23:46 ` Nicolas Goaziou
2019-01-07  1:13   ` stardiviner
2019-01-09 22:29     ` Nicolas Goaziou
2019-01-07  6:07   ` stardiviner

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).