From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: BUG - ox-latex - bib expansion bug and documentation error Date: Thu, 11 Jul 2019 00:07:48 -0400 Message-ID: <877e8p1aej.fsf@kyleam.com> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:56387) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlQNA-0005fX-5M for emacs-orgmode@gnu.org; Thu, 11 Jul 2019 00:07:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlQN8-0001eM-Ln for emacs-orgmode@gnu.org; Thu, 11 Jul 2019 00:07:56 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:59419) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hlQN7-0001YH-NH for emacs-orgmode@gnu.org; Thu, 11 Jul 2019 00:07:53 -0400 In-Reply-To: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Guilherme Passos , "emacs-orgmode@gnu.org" Hi Guilherme, Guilherme Passos writes: > In ox-latex.el, line 1189, org-latex-pdf-process uses '(%bib %b) for > expanding the bibliography. However, this incorrectly expands as > '(BIBFILEib BIBFILE), instead of '(BIBPROCESS BIBFILE) as intended, > defining the process of calling the bibliography. > > As can be seen in line 3635, the correct command for the bibprocess is > %B, not %bib. The documentation is also wrong in lines 1137 and 1160 > for saying that %bib is the correct command. I don't use ox-latex.el and may be missing something, but looking at the code I think %bib, as described by the docstring of org-latex-pdf-process, is intended. When %bib was added in 74da3bc10 (ox-latex: Support arbitrary bibtex-like program, 2015-07-08), it appears that it was working as documented. But with the switch to using format-spec internally in f6187deca (ox-latex: Small refactor, 2015-09-13), the field was changed from %bib to %bibtex. Based on the commit message, I don't think that was intentional. > The only thing necessary is to replace %bib with %B in those lines. Given the situation I described above, I think the options are * change %bib to %B (your suggestion) and remove the "bib" part from the regexp in org-latex-compile because keeping it around would be confusing * update the documentation and type in org-latex-pdf-process to use %bibtex * update the regexp in org-latex-compile to match "bib", not "bibtex" The last one seems preferable to me, assuming the change from %bib to %bibtex was an oversight. What do you think? > Should I send a patch? Yes, please. -- Kyle