From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2Pc+FOaylV4zPQAA0tVLHw (envelope-from ) for ; Tue, 14 Apr 2020 12:56:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yHAZCOmylV5hdQAAB5/wlQ (envelope-from ) for ; Tue, 14 Apr 2020 12:56:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 27CA5941B04 for ; Tue, 14 Apr 2020 12:56:07 +0000 (UTC) Received: from localhost ([::1]:60214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOL6i-000502-LI for larch@yhetil.org; Tue, 14 Apr 2020 08:56:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37647) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOL6J-0004zs-D0 for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 08:55:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOL6I-0005pS-36 for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 08:55:38 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:56289) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOL6H-0005om-TD for emacs-orgmode@gnu.org; Tue, 14 Apr 2020 08:55:38 -0400 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 93847200009; Tue, 14 Apr 2020 12:55:34 +0000 (UTC) From: Nicolas Goaziou To: stardiviner Subject: Re: [SOLVED] Re: [PATCH] Show hidden drawers when org-cycle on headlines References: <87ftdact0g.fsf@gmail.com> <87eesu2ekz.fsf@nicolasgoaziou.fr> <87d08c9i7j.fsf@gmail.com> <87ftd7agwl.fsf@localhost> <877dyj9wkc.fsf@gmail.com> <87k12j491l.fsf@localhost> <87wo6jw3yi.fsf@nicolasgoaziou.fr> <87eesqmylz.fsf@gmail.com> Mail-Followup-To: stardiviner , emacs-orgmode@gnu.org, Ihor Radchenko Date: Tue, 14 Apr 2020 14:55:33 +0200 In-Reply-To: <87eesqmylz.fsf@gmail.com> (stardiviner's message of "Tue, 14 Apr 2020 13:21:12 +0800") Message-ID: <877dyi1b22.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.178.232 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Ihor Radchenko Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.01 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.57606379700824]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.28), country: US(-0.01), ip: 209.51.188.17(-0.58)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; MAILLIST(-0.20)[mailman]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; FREEMAIL_CC(0.00)[gnu.org,gmail.com]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: SIyX9Div2JqN Hello, stardiviner writes: > I agree. As I described in my given example "org-contacts", which include person > info in properties drawer. That's why I want to expand when I press "Tab" on > expanding headline. If I see a contact's info with "C-u C-u C-u Tab" is not > convenient. You can rebind it. > Is it possible to change "org-cycle-hide-drawers" to "org-cycle-toggle-drawers". > Make it more extendable. Because that function only changed one argument of > "org-flag-drawer". If so some user like me will be easy to toggle hide/show > drawers. (Of course, I don't want to add redundant code in my Emacs init.) If > this is fine, I will re-edit my patch. Remove defcustom option, and hook on > cycle. Only keep changes in "org-cycle-hide-drawers". I think something is wrong with `org-cycle-hide-drawers' at the moment. This function was initially meant to be added to `org-cycle-hook' to re-hide drawers. It should only re-hide properties drawers. In any case, it is not needed to expand this function, it should be trimmed down to only take care of property drawers. What is needed, though, it a tooling similar to block visibility functions, i.e., `org-hide-block-toggle', `org-hide-block-hall', and, maybe, `org-hide-block-toggle-maybe'. Regular drawers should get the same treatment as blocks. If you look at `org-cycle' code, there is a comment ;; Drawers: delegate to `org-flag-drawer'. This part should be extracted into a new function. Regards, -- Nicolas Goaziou