From: Kyle Meyer <kyle@kyleam.com> To: ian martins <ianxm@jhu.edu> Cc: Emacs-orgmode@gnu.org Subject: Re: org-babel support for haxe Date: Sun, 06 Sep 2020 11:24:16 -0400 [thread overview] Message-ID: <877dt72ajj.fsf@kyleam.com> (raw) In-Reply-To: <CAC=rjb6FnA=WuMK_qfto=rFfH=QZHet_-7AXd26NQ-Ktjd5y8w@mail.gmail.com> Hi ian, It looks like this library is instead going to be available through an ELPA, but FWIW here are a couple of comments on the tests. ian martins writes: > diff --git a/testing/examples/ob-haxe-test.org b/testing/examples/ob-haxe-test.org > new file mode 100644 > index 000000000..ba9119d58 > --- /dev/null > +++ b/testing/examples/ob-haxe-test.org > @@ -0,0 +1,247 @@ > +#+Title: a collection of examples for ob-haxe tests > +#+OPTIONS: ^:nil > +* Simple > + :PROPERTIES: > + :ID: 966875e9-d10e-406c-9211-449555e3d3b2 > + :END: > +#+name: simple > +#+begin_src haxe :results output silent > + Sys.print(42); > +#+end_src I know some other babel tests use a separate .org file, but I find this setup harder to follow compared to having the Org content within the test (e.g. using org-test-with-temp-text or org-test-with-temp-text-in-file). Perhaps I'm missing why it's needed in this case though. > diff --git a/testing/lisp/test-ob-haxe.el b/testing/lisp/test-ob-haxe.el [...] > +;;; Code: > +(org-test-for-executable "haxe") > +(unless (featurep 'ob-haxe) > + (signal 'missing-test-dependency "Support for haxe code blocks")) > + > +(ert-deftest ob-haxe/simple () > + "Hello world program." > + (if (executable-find org-babel-haxe-command) I think you can avoid the executable-find here and in all the other tests because you have (org-test-for-executable "haxe") at the beginning of the file.
next prev parent reply other threads:[~2020-09-06 15:25 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-12 4:37 ian martins 2020-09-05 7:24 ` Bastien 2020-09-05 11:48 ` ian martins 2020-09-06 15:24 ` Kyle Meyer [this message] 2020-09-12 15:18 ` ian martins 2020-09-13 20:04 ` Kyle Meyer 2020-09-24 21:17 ` ian martins 2020-09-30 10:08 ` ian martins
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=877dt72ajj.fsf@kyleam.com \ --to=kyle@kyleam.com \ --cc=Emacs-orgmode@gnu.org \ --cc=ianxm@jhu.edu \ --subject='Re: org-babel support for haxe' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).