From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id k3JvAnOJYV84CQAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 03:41:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id wD3ZN3KJYV9LKwAA1q6Kng (envelope-from ) for ; Wed, 16 Sep 2020 03:41:38 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7E29940415 for ; Wed, 16 Sep 2020 03:41:37 +0000 (UTC) Received: from localhost ([::1]:47946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIOK6-0000xS-Kz for larch@yhetil.org; Tue, 15 Sep 2020 23:41:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIOHy-0008Rk-34 for emacs-orgmode@gnu.org; Tue, 15 Sep 2020 23:39:22 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:58137) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIOHv-00032b-QW for emacs-orgmode@gnu.org; Tue, 15 Sep 2020 23:39:21 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id E784381612 for ; Tue, 15 Sep 2020 23:39:16 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=tyHnviVNwjOb TsVrxQV0+nNmG04=; b=jZQml54ddxE5xcLYaWrCWIaOvVPKSB8Pxc4aSZntrBkv Sl3SVYD4kQhq63ai04gn/LuARYjpYYkl5Ymx7nZiLUzAOYJZE7nSZG4FQkNuRGhf ag1QpP5D6tNIqRS1QrEa6WQLwHH8xwCdJ6nCbheK593/oS7PMGchuMS/m7g91WI= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id DF6EC81611 for ; Tue, 15 Sep 2020 23:39:16 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=wU1092Ddwy+6sTdDNcG0Qp6Ll+GJOrmSR68g7kAH0rc=; b=wXAB6sL18lFRvW3cKXiooCaM4vs6LRc6N6SjcGn9iajom+YiMJvESYoFPoFDzicFmWzrrxCBbHyYviyrutSrzPguOuR9UArCupMwpolXTH4gCi+pnuuQA3sUbYlLLFTQQ/e8A9itOUXWO0PIbxWxsktrKbr6Hs25tmIU7kHp1f4= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 7696A81610 for ; Tue, 15 Sep 2020 23:39:16 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: emacs-orgmode@gnu.org Subject: pcase failure with Emacs 24 (was Emacs version for Org 9.4?) In-Reply-To: <87pn6n5u13.fsf@wi.uni-muenster.de> References: <87pn6n5u13.fsf@wi.uni-muenster.de> Date: Tue, 15 Sep 2020 23:39:15 -0400 Message-ID: <877dsu75lo.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: 322754CC-F7CE-11EA-8F9D-2F5D23BA3BAF-24757444!pb-smtp2.pobox.com Received-SPF: pass client-ip=64.147.108.71; envelope-from=kyle@kyleam.com; helo=pb-smtp2.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 23:39:17 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=jZQml54d; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=wXAB6sL1; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.21 X-TUID: n1O/Rj4zMp+Z Jens Lechtenboerger writes: > Hi there, > > if I open an Org file on > =E2=80=9CGNU Emacs 24.5.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of > 2017-09-12 on hullmann, modified by Debian=E2=80=9D > I get this error (which I don=E2=80=99t know how to debug): > > Eager macro-expansion failure: (wrong-type-argument listp :pcase--succeed) [...] > In ORG-NEWS, I only found that =E2=80=9CEmacs 24.4 or above is suggested.= =E2=80=9D > Did that change? No, it didn't. It is pretty tricky to debug, but the failure starts with 4a27b67fd (org-element: Fix property drawers parsing, 2020-04-22). As far as I can see, the pattern introduced there is perfectly valid and should be compatible with Emacs 24. I'd _guess_ this is a pcase bug in Emacs 24, particularly the one fixed by 528872c5f8 (bug#18554, 2014-09-27), but I didn't make an effort to try to understand that commit. Interestingly, the error goes away if I just swap the elements in the pcase (and ...) pattern added by that commit. Dunno, but if that clears up the failure on your end as well, I don't see any reason to not make that change. diff --git a/lisp/org-element.el b/lisp/org-element.el index a693cb68d..755de8661 100644 --- a/lisp/org-element.el +++ b/lisp/org-element.el @@ -4324,7 +4324,7 @@ (defsubst org-element--next-mode (mode type parent?) (if parent? (pcase type (`headline 'section) - ((and `section (guard (eq mode 'first-section))) 'top-comment) + ((and (guard (eq mode 'first-section)) `section) 'top-comment) (`inlinetask 'planning) (`plain-list 'item) (`property-drawer 'node-property)