From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6h2EEYUn0mD+LgEAgWs5BA (envelope-from ) for ; Tue, 22 Jun 2021 20:10:13 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uK2XDIUn0mD/JAAA1q6Kng (envelope-from ) for ; Tue, 22 Jun 2021 18:10:13 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0AFA24F10 for ; Tue, 22 Jun 2021 20:10:12 +0200 (CEST) Received: from localhost ([::1]:56332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvkqh-0007mx-IX for larch@yhetil.org; Tue, 22 Jun 2021 14:10:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36490) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvkpe-0006qO-LL for emacs-orgmode@gnu.org; Tue, 22 Jun 2021 14:09:06 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvkpb-000459-CU for emacs-orgmode@gnu.org; Tue, 22 Jun 2021 14:09:06 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id CD995E0004; Tue, 22 Jun 2021 18:08:59 +0000 (UTC) From: Nicolas Goaziou To: =?utf-8?Q?Andr=C3=A1s?= Simonyi Subject: Re: [wip-cite-new] experimental citeproc-el based activation processor References: <87sg1nta2t.fsf@nicolasgoaziou.fr> <87im2jytoy.fsf@gmail.com> <87fsxnytln.fsf@gmail.com> <87a6nuuavg.fsf@nicolasgoaziou.fr> Mail-Followup-To: =?utf-8?Q?Andr=C3=A1s?= Simonyi , Timothy , emacs-orgmode list Date: Tue, 22 Jun 2021 20:08:58 +0200 In-Reply-To: (=?utf-8?Q?=22Andr=C3=A1s?= Simonyi"'s message of "Tue, 15 Jun 2021 09:12:21 +0200") Message-ID: <877dilhiv9.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode list , Timothy Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624385412; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=rp6K/rYKvI1fucW2/WXfpsz41lwaAMdqmKpH7g6JghY=; b=njm6wouXL5UCnTAHYbmNzafBp2ZgGsHVktWiAIGGriGOXSPU7ZeBGKLbMehUtX9I7QzkRs k1rX0JG5UY3PHqRfpCSXy6NEKtWuBIrgR7E8RYfVDD30nLOQj+KAvtBGGmTvZsc8QfYr9Y wPT2VaNZv4Hg9h5VYyUehzxIQPjEd/R9uGg+6osIf493qEKMhFJBX7VIll9644jgJX4LgP E0u+PXCTYs5DLeVAt+PuJz7ICyn0CE/+eZ3GsE9INIUBjBt3uSQuLRdtG7R1W8zg2gNtLo p+67f0NDPyA0nzP0k3XB5tRV52LwGNszpACaYqOnI/+hR5+Y6sM2CfwvtwTKYA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624385412; a=rsa-sha256; cv=none; b=jCD3QTfBy43Ie7Z+2Zdot6iRpCraRqM9Kv6pn0DygsVdWJ1gtkhP3Kuvj1QmWm1NirzF1b 8QLUQDbnpBj98JUWhwmDCZ7nDoX58/IV/tilB0fIXcBp3QL3LCKpaBL2NQGn2K4I9sDCH+ +GwyalaCJouNc0x/ZYM77V0iVAixfSrliHX8mEfdZE1M8KqfXVA1reV+n2zZiGrEGbEpoc INn3URhFN7VRm66ij/YR4/mQCVUZdREOhvyP96y4FUHrJXaQAUU8hSP8T7y2LXWHV4bNsx OMA+Duy6f2/qnjgHrHpRz1bM1fD43EeSoTRAmBXl1NSW6wuoX4gyJAX/tYRvhA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: A0AFA24F10 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2kAe3kEvVuXP Hello, Andr=C3=A1s Simonyi writes: >> - As suggested by Bruce D'Arcus, we might move `org-cite-get-boundaries' >> in `oc.el' proper, since it is also used elsewhere (at least in >> "oc-basic.el"). > > sure, it makes more sense there, especially because I took the > fragment from your code IIRC (apologies for the lack of explicit > attribution) No problem: I stole it back from you! ;) I added `org-cite-boundaries' to "oc.el", so your library can make use of it (after a rebase). >> - Nitpick: (car element) =3D> (org-element-type element) > > I was actually wondering about this when I wrote the code and if I may > nitpick on the nitpick, I find the documentation a bit confusing in > this respect. If the list representation is meant to be > internal/private only (I guess that is the case), then maybe this > should be more explicit in the docstrings, because now the docstring > of `org-element-context' says > > "Return smallest element or object around point. > > Return value is a list like (TYPE PROPS) [...]" > > Omitting the second part or having something like "Internally, return > value is [...]" would go a long way toward conveying the message that > one shouldn't rely on the list representation. It's not that one shouldn't rely on the list representation, but the expressiveness of `car' is very low, whereas `org-element-type' is explicit. I was merely suggesting to lean towards expressiveness here. Regards, --=20 Nicolas Goaziou