From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6KvMA9fTXGFSXAEAgWs5BA (envelope-from ) for ; Wed, 06 Oct 2021 00:38:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id UAYEO9bTXGHeSAAAB5/wlQ (envelope-from ) for ; Tue, 05 Oct 2021 22:38:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E0AECB095 for ; Wed, 6 Oct 2021 00:38:13 +0200 (CEST) Received: from localhost ([::1]:39194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXt4d-00075k-6h for larch@yhetil.org; Tue, 05 Oct 2021 18:38:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54442) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXt4F-00075c-3K for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 18:37:47 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:41882) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXt4D-0001eH-6G for emacs-orgmode@gnu.org; Tue, 05 Oct 2021 18:37:46 -0400 Received: by mail-wr1-x429.google.com with SMTP id t2so2489191wrb.8 for ; Tue, 05 Oct 2021 15:37:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:user-agent:mime-version; bh=6GMaNZ1Wk7jIG7YDvqRKjpNFys6i4wz9k5EqIOnWEes=; b=i1or872xrDo3TRWKcTO3ovOy+fOshU6OFTb1P2UoqFv2fLsZeXPY2BigQS1hSz9ZwZ 0NpPLhIGbel/lwstU+mJSBRRS2xwxHtYxyHuiVijLOh/V78o2RXXs67zD4eKNM+QECz0 M2aJ2eoLJuzx07TOYkTtcHHSxSI4E1kWfQk28bshopnhX6dysD+iTd3iMMf59decX4Mg ioRTGPynRLMYcvjFYWWImGFhPrkplR8CdKZn3LQr3XPFAROvtBivLHQ1n94PcX2vHi9y Qtwm2UOqj/Ex/CW+hGrn6W8PGXPcWQjWHOkXSR4fMjWx+Cly132Fu/fwqn1vt6dGnGRO HdMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:user-agent :mime-version; bh=6GMaNZ1Wk7jIG7YDvqRKjpNFys6i4wz9k5EqIOnWEes=; b=tmcIo7nMBNMKXXz/fW5os3IB8eKPQsQd/JAFFJcVjq4hxlRwG7NXLR9MKrc8T9CojM hcxrYiEHRXf1Fh6Y8wjgOjFbZ68VR2PN+4ZKCdIhS+2bsI2GTudYo2NurGkrW7Oi1vIP EBamPL0YE4r+V/PCfuTvG4Nv8L5IzS2g6xYHO5ehwdE/A6rHWFPKoSIHwQlq8C+Wwk0U uZwewgHvUTO6g3r0xZEniRrkSRBLidCQ9lH0l5qOeh/0GnKDw/7TF0/DiN1z9cmU+bm4 PEKhIYMD1HQ3y0xBwKjiqMT5qx2bR8hfzAP9nSOd/FF1lFIFmlv1OoBcTj8pC0AiV6LH bd1g== X-Gm-Message-State: AOAM530xKs1+CWhuXm6/1biiaudK7vvPwF1SBx2j4MUrxPS7B4JjD5YE RuMsqPnQ1LAru4otasDgnhFjD+DjbMLN2Q== X-Google-Smtp-Source: ABdhPJxhle+/mKpRVtqwEuePtknuyGR3M+CCKW2uF3ImfzL8tnpxnFNaumsffZ4XxpxxPwJee8o6wg== X-Received: by 2002:a5d:6d8e:: with SMTP id l14mr24519656wrs.270.1633473463064; Tue, 05 Oct 2021 15:37:43 -0700 (PDT) Received: from localhost (ip-95-223-72-106.hsi16.unitymediagroup.de. [95.223.72.106]) by smtp.gmail.com with ESMTPSA id e8sm3061398wme.46.2021.10.05.15.37.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 15:37:42 -0700 (PDT) From: Jeremie Juste To: Org Mode Subject: [PATCH] ob-R async evaluation Date: Wed, 06 Oct 2021 00:37:38 +0200 Message-ID: <877derdrnx.fsf@debian-BULLSEYE-live-builder-AMD64> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=jeremiejuste@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_FREEMAIL_DOC_PDF=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633473494; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6GMaNZ1Wk7jIG7YDvqRKjpNFys6i4wz9k5EqIOnWEes=; b=rhnnzYk+Rh+Kp9svdI5byT67WvxJrwsuST83I9E7Hn3p72V+etiWyaDdorKzNSrJzcnPFl EW0kbW7Ll8Cm6zkGhDL7eFp+CY1Ijzu9xNMCgH+e43yenedA8wEcXvqC+27FtRo6U1zV/p UMuQcJnN8GV0WKC06h/vAPt4EHd1dWlN1WHghMuT5HScHTyBIy1Bh2Ucbd8P3u8N+uU97M X2uKrKlzUwmrahQR79UD23VfUs8LKyyQ3IaFMiNB0Lyr6/4UlfYL9IRGWY85FzkyLzV5Wm BLKTk0JGodKE9CPL2x3bSzN4FQGn+ql8Nnuh1zaZWaapfuuVBkkEKDOjtjBnMw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633473494; a=rsa-sha256; cv=none; b=bmP+SaiyHDRC4goN+r1k3vRqPI3w977EG8kYdCrGGp22MTqPGh4Oxc/ZtAuuYHYvaEnHSU bhVqgjjhlgmyeWzXvg+9M2Ct+pVHZBdF5tHFamn0hJaBFuNMiuMJid/YYA6FqpSAwG/Way x41qg5lWY4x3d0v2imz/vBrh4yVqUu3Lp7HFYqrbLUCC5D8FmCcU0kdZS8CC3u0F1mysa8 y1jvZ0YB+wTOQRUj8uxJaqaHsCAKKriNHjmJ4sw48O87qvki+Z2aUlb9mYuqG4h8fCyikV uealNJO9Wp1zIy135IoO0FsNyTeZua6ZQKnbHzem3F7kjV5lxLs3Q2gJ+4+x2A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=i1or872x; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.61 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=i1or872x; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E0AECB095 X-Spam-Score: -2.61 X-Migadu-Scanner: scn0.migadu.com X-TUID: Iy/YDSA/MTUm --=-=-= Content-Type: text/plain Hello, I'm attaching a patch that clean up a bit of non conventional coding practices (mainly because of my ignorance), in ob-R. These were initially generating warning during the compilation of org-mode. The main feature is the use of the defvaralias ess-eval-visibly-p when the :result output in async evaluation. With this change make does not generate any warning for ob-R.el and all the test of ob-R.el passes, so no significant change for the user. Best regards, Jeremie --=-=-= Content-Type: application/pdf Content-Disposition: attachment; filename=0001-ob-R.el-Patch-4-async-evaluation.patch Content-Transfer-Encoding: base64 RnJvbSAzN2QxOGZjMDQwZTU0MmNhNTE3NTA5YWZmNTJhOWY1NjQ5OTFlYWMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXJlbWllIEp1c3RlIDxkampAZGViaWFuLUJVTExTRVlFLWxp dmUtYnVpbGRlci1BTUQ2ND4KRGF0ZTogV2VkLCA2IE9jdCAyMDIxIDAwOjExOjEwICswMjAwClN1 YmplY3Q6IFtQQVRDSF0gb2ItUi5lbDogUGF0Y2ggNCBhc3luYyBldmFsdWF0aW9uCgoqIG9iLVIu ZWwgKG9iLXNlc3Npb24tYXN5bmMtb3JnLWJhYmVsLVItZXZhbHVhdGUtc2Vzc2lvbik6IFVzZQpk ZWZ2YXJhbGlhcyBgZXNzLWV2YWwtdmlzaWJseS1wJyBpbnN0ZWFkIG9mIG1vZGlmeWluZyB1c2Vy LWRlZmluZWQKdmFyaWFibGUuIFJlbW92ZSB0ZW1wb3JhcnkgZGVjbGFyYXRpb24gdGhhdCBzaWxl bmNlcyB0aGUgYnl0ZS1jb21waWxlci4KCiogb2ItUi5lbCAob3JnLWJhYmVsLVItZXZhbHVhdGUs b2Itc2Vzc2lvbi1hc3luYy1vcmctYmFiZWwtUi1ldmFsdWF0ZS1zZXNzaW9uKTogUmVtb3ZlCnBh cmFtZXRlciBgcmVzdWx0LXBhcmFtcycgaW4KKG9iLXNlc3Npb24tYXN5bmMtb3JnLWJhYmVsLVIt ZXZhbHVhdGUtc2Vzc2lvbikgYW5kIHdoZXJlIGl0IGlzIGNhbGxlZAppbiAob3JiLWJhYmVsLVIt ZXZhbHVhdGUpLgotLS0KIGxpc3Avb2ItUi5lbCB8IDMyICsrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vYi1SLmVsIGIvbGlzcC9vYi1SLmVsCmluZGV4IDQ5MjU2 MDQxMi4uOTNjZTFjY2IwIDEwMDY0NAotLS0gYS9saXNwL29iLVIuZWwKKysrIGIvbGlzcC9vYi1S LmVsCkBAIC00MCwxMyArNDAsNiBAQAogKGRlY2xhcmUtZnVuY3Rpb24gZXNzLXdhaXQtZm9yLXBy b2Nlc3MgImV4dDplc3MtaW5mIgogCQkgICgmb3B0aW9uYWwgcHJvYyBzZWMtcHJvbXB0IHdhaXQg Zm9yY2UtcmVkaXNwbGF5KSkKIAotOzsgRklYTUU6IFRlbXBvcmFyeSBkZWNsYXJhdGlvbiB0byBz aWxlbmNlIHRoZSBieXRlLWNvbXBpbGVyCi0oZGVmdmFyIHVzZXItaW5qZWN0LXNyYy1wYXJhbSkK LShkZWZ2YXIgZXNzLWV2YWwtdmlzaWJseS10bXApCi0oZGVmdmFyIGVzcy1ldmFsLXZpc2libHkp Ci0oZGVmdmFyIGVzcy1pbmplY3Qtc291cmNlKQotKGRlZnZhciB1c2VyLWluamVjdC1zcmMtcGFy YW0pCi0KIChkZWZjb25zdCBvcmctYmFiZWwtaGVhZGVyLWFyZ3M6UgogICAnKCh3aWR0aAkJIC4g OmFueSkKICAgICAoaGVpZ2h0CQkgLiA6YW55KQpAQCAtMzMxLDcgKzMyNCw3IEBAIEVhY2ggbWVt YmVyIG9mIHRoaXMgbGlzdCBpcyBhIGxpc3Qgd2l0aCB0aHJlZSBtZW1iZXJzOgogCSAoZGV2aWNl LWluZm8gKG9yIChhc3NxIChpbnRlcm4gKGNvbmNhdCAiOiIgZGV2aWNlKSkKIAkJCQlvcmctYmFi ZWwtUi1ncmFwaGljcy1kZXZpY2VzKQogICAgICAgICAgICAgICAgICAgICAgICAgICAoYXNzcSA6 cG5nIG9yZy1iYWJlbC1SLWdyYXBoaWNzLWRldmljZXMpKSkKLSAgICAgICAgIChleHRyYS1hcmdz IChjZHIgKGFzc3EgOlItZGV2LWFyZ3MgcGFyYW1zKSkpIGZpbGVhcmcgYXJncykKKyAgICAgICAg KGV4dHJhLWFyZ3MgKGNkciAoYXNzcSA6Ui1kZXYtYXJncyBwYXJhbXMpKSkgZmlsZWFyZyBhcmdz KQogICAgIChzZXRxIGRldmljZSAobnRoIDEgZGV2aWNlLWluZm8pKQogICAgIChzZXRxIGZpbGVh cmcgKG50aCAyIGRldmljZS1pbmZvKSkKICAgICAoc2V0cSBhcmdzIChtYXBjb25jYXQKQEAgLTM4 MCwxNCArMzczLDE0IEBAIEhhcyBmb3VyICVzIGVzY2FwZXMgdG8gYmUgZmlsbGVkIGluOgogNC4g VGhlIG5hbWUgb2YgdGhlIGZpbGUgdG8gd3JpdGUgdG8iKQogCiAoZGVmdW4gb3JnLWJhYmVsLVIt ZXZhbHVhdGUKLSAgICAoc2Vzc2lvbiBib2R5IHJlc3VsdC10eXBlIHJlc3VsdC1wYXJhbXMgY29s dW1uLW5hbWVzLXAgcm93LW5hbWVzLXAgYXN5bmMpCisgIChzZXNzaW9uIGJvZHkgcmVzdWx0LXR5 cGUgcmVzdWx0LXBhcmFtcyBjb2x1bW4tbmFtZXMtcCByb3ctbmFtZXMtcCBhc3luYykKICAgIkV2 YWx1YXRlIFIgY29kZSBpbiBCT0RZLiIKICAgKGlmIHNlc3Npb24KICAgICAgIChpZiBhc3luYwog ICAgICAgICAgIChvYi1zZXNzaW9uLWFzeW5jLW9yZy1iYWJlbC1SLWV2YWx1YXRlLXNlc3Npb24K LSAgICAgICAgICAgc2Vzc2lvbiBib2R5IHJlc3VsdC10eXBlIHJlc3VsdC1wYXJhbXMgY29sdW1u LW5hbWVzLXAgcm93LW5hbWVzLXApCi0gICAgICAgIChvcmctYmFiZWwtUi1ldmFsdWF0ZS1zZXNz aW9uCi0gICAgICAgICBzZXNzaW9uIGJvZHkgcmVzdWx0LXR5cGUgcmVzdWx0LXBhcmFtcyBjb2x1 bW4tbmFtZXMtcCByb3ctbmFtZXMtcCkpCisgICAgICAgICAgIHNlc3Npb24gYm9keSByZXN1bHQt dHlwZSAgY29sdW1uLW5hbWVzLXAgcm93LW5hbWVzLXApCisgICAgICAob3JnLWJhYmVsLVItZXZh bHVhdGUtc2Vzc2lvbgorICAgICAgIHNlc3Npb24gYm9keSByZXN1bHQtdHlwZSByZXN1bHQtcGFy YW1zIGNvbHVtbi1uYW1lcy1wIHJvdy1uYW1lcy1wKSkKICAgICAob3JnLWJhYmVsLVItZXZhbHVh dGUtZXh0ZXJuYWwtcHJvY2VzcwogICAgICBib2R5IHJlc3VsdC10eXBlIHJlc3VsdC1wYXJhbXMg Y29sdW1uLW5hbWVzLXAgcm93LW5hbWVzLXApKSkKIApAQCAtNDg2LDcgKzQ3OSw3IEBAIEluc2Vy dCBobGluZSBpZiBjb2x1bW4gbmFtZXMgaW4gb3V0cHV0IGhhdmUgYmVlbiByZXF1ZXN0ZWQuIgog KGRlZmNvbnN0IG9iLXNlc3Npb24tYXN5bmMtUi1pbmRpY2F0b3IgIidvYl9jb21pbnRfYXN5bmNf Ul8lc18lcyciKQogCiAoZGVmdW4gb2Itc2Vzc2lvbi1hc3luYy1vcmctYmFiZWwtUi1ldmFsdWF0 ZS1zZXNzaW9uCi0gICAgKHNlc3Npb24gYm9keSByZXN1bHQtdHlwZSBfIGNvbHVtbi1uYW1lcy1w IHJvdy1uYW1lcy1wKQorICAgIChzZXNzaW9uIGJvZHkgcmVzdWx0LXR5cGUgY29sdW1uLW5hbWVz LXAgcm93LW5hbWVzLXApCiAgICJBc3luY2hyb25vdXNseSBldmFsdWF0ZSBCT0RZIGluIFNFU1NJ T04uCiBSZXR1cm5zIGEgcGxhY2Vob2xkZXIgc3RyaW5nIGZvciBpbnNlcnRpb24sIHRvIGxhdGVy IGJlIHJlcGxhY2VkCiBieSBgb3JnLWJhYmVsLWNvbWludC1hc3luYy1maWx0ZXInLiIKQEAgLTUy NSwyMiArNTE4LDE3IEBAIGJ5IGBvcmctYmFiZWwtY29taW50LWFzeW5jLWZpbHRlcicuIgogICAg IChvdXRwdXQKICAgICAgKGxldCAoKHV1aWQgKG1kNSAobnVtYmVyLXRvLXN0cmluZyAocmFuZG9t IDEwMDAwMDAwMCkpKSkKICAgICAgICAgICAgKGVzcy1sb2NhbC1wcm9jZXNzLW5hbWUKLSAgICAg ICAgICAgIChwcm9jZXNzLW5hbWUgKGdldC1idWZmZXItcHJvY2VzcyBzZXNzaW9uKSkpKQorICAg ICAgICAgICAgKHByb2Nlc3MtbmFtZSAoZ2V0LWJ1ZmZlci1wcm9jZXNzIHNlc3Npb24pKSkKKyAg ICAgICAgICAgKGVzcy1ldmFsLXZpc2libHktcCBuaWwpKQogICAgICAgICh3aXRoLXRlbXAtYnVm ZmVyCiAgICAgICAgICAoaW5zZXJ0IChmb3JtYXQgb2Itc2Vzc2lvbi1hc3luYy1SLWluZGljYXRv cgotCQkJICJzdGFydCIgdXVpZCkpCisJCQkJCSAgInN0YXJ0IiB1dWlkKSkKICAgICAgICAgIChp bnNlcnQgIlxuIikKICAgICAgICAgIChpbnNlcnQgYm9keSkKICAgICAgICAgIChpbnNlcnQgIlxu IikKICAgICAgICAgIChpbnNlcnQgKGZvcm1hdCBvYi1zZXNzaW9uLWFzeW5jLVItaW5kaWNhdG9y CiAJCQkgImVuZCIgdXVpZCkpCi0gICAgICAgICAoc2V0cSBlc3MtZXZhbC12aXNpYmx5LXRtcCBl c3MtZXZhbC12aXNpYmx5KQotICAgICAgICAgKHNldHEgdXNlci1pbmplY3Qtc3JjLXBhcmFtIGVz cy1pbmplY3Qtc291cmNlKQotICAgICAgICAgKHNldHEgZXNzLWV2YWwtdmlzaWJseSBuaWwpCi0g ICAgICAgICAoc2V0cSBlc3MtaW5qZWN0LXNvdXJjZSAnZnVuY3Rpb24tYW5kLWJ1ZmZlcikKLSAg ICAgICAgIChlc3MtZXZhbC1idWZmZXIgbmlsKSkKLSAgICAgICAoc2V0cSBlc3MtZXZhbC12aXNp Ymx5IGVzcy1ldmFsLXZpc2libHktdG1wKQotICAgICAgIChzZXRxIGVzcy1pbmplY3Qtc291cmNl IHVzZXItaW5qZWN0LXNyYy1wYXJhbSkKKyAgICAgICAgIChlc3MtZXZhbC1idWZmZXIgbmlsICkp CiAgICAgICAgdXVpZCkpKSkKIAogKGRlZnVuIG9iLXNlc3Npb24tYXN5bmMtUi12YWx1ZS1jYWxs YmFjayAocGFyYW1zIHRtcC1maWxlKQotLSAKMi4zMC4yCgo= --=-=-=--