emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Marco Wahl <marcowahlsoft@gmail.com>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix parallel build failure for Texinfo manual
Date: Tue, 21 Dec 2021 12:21:25 +0100	[thread overview]
Message-ID: <877dby19vu.fsf@gmail.com> (raw)
In-Reply-To: <ua6guh0vq@gentoo.org> (Ulrich Mueller's message of "Tue, 21 Dec 2021 08:29:13 +0100")

Ulrich Mueller <ulm@gentoo.org> writes:

>>>>>> On Mon, 20 Dec 2021, Marco Wahl wrote:
>
>> Possibly a split of function org-make-manuals in org-make-manual and
>> org-make-guide and further create two single targets instead of the
>> current double target is more clear.
>
>> See the patch.
>
>> WDYT?
>
> Sure, that's much cleaner. (I didn't dare to change the elisp code
> because it is also more intrusive.)
>
>> -org.texi orgguide.texi:	org-manual.org org-guide.org
>> +org.texi:	org-manual.org org-guide.org
>
> Shouldn't it have only org-manual.org as prerequisite?
>
>>  	$(BATCH) 				      \
>>  	  --eval '(add-to-list `load-path "../lisp")' \
>>  	  --eval '(load "../mk/org-fixup.el")' 	      \
>> -	  --eval '(org-make-manuals)'
>> +	  --eval '(org-make-manual)'
>> +
>> +orgguide.texi:	org-manual.org org-guide.org
>
> Similar here, only org-guide.org?
>
>> +	$(BATCH) 				      \
>> +	  --eval '(add-to-list `load-path "../lisp")' \
>> +	  --eval '(load "../mk/org-fixup.el")' 	      \
>> +	  --eval '(org-make-guide)'

Yes, thanks.

The issue should be fixed with a slightly more defensive change than
stated in the last patch (by keeping function org-make-manuals.)


Thanks again,
-- 
Marco



  reply	other threads:[~2021-12-21 11:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 16:44 Ulrich Müller
2021-12-20 21:39 ` Marco Wahl
2021-12-21  7:29   ` Ulrich Mueller
2021-12-21 11:21     ` Marco Wahl [this message]
2021-12-21 12:17   ` Max Nikulin
2021-12-21 12:48     ` Marco Wahl
2021-12-21 14:37       ` Max Nikulin
2021-12-21 20:34         ` Marco Wahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dby19vu.fsf@gmail.com \
    --to=marcowahlsoft@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ulm@gentoo.org \
    --subject='Re: [PATCH] Fix parallel build failure for Texinfo manual' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).