From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CIJiGI0MeWJ6bgAAbAwnHQ (envelope-from ) for ; Mon, 09 May 2022 14:43:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 0Gx0F40MeWIyagEAG6o9tA (envelope-from ) for ; Mon, 09 May 2022 14:43:57 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE9761BCB5 for ; Mon, 9 May 2022 14:43:56 +0200 (CEST) Received: from localhost ([::1]:48230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no2jz-0008OV-S9 for larch@yhetil.org; Mon, 09 May 2022 08:43:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60976) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no2eV-0003Wh-DM for emacs-orgmode@gnu.org; Mon, 09 May 2022 08:38:15 -0400 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]:38595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no2eT-0007iO-Mv for emacs-orgmode@gnu.org; Mon, 09 May 2022 08:38:15 -0400 Received: by mail-qv1-xf2f.google.com with SMTP id n10so848697qvi.5 for ; Mon, 09 May 2022 05:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=LF6PDi9hHIc/Ge1yXM0Z9pr+qeYYlpE6O6Dd716Xf/U=; b=b+uO1hABpHJEtAgwc2ZTsu6KoQVzkDzN8j9m6f33pucQc0i0FATzeJwU4EYPRtPbSx 1EOhGdOA/1RpPjt9AHVwk/q35dI/TLEOaTGLcjZCTIQHPFzCBZIEInXOILPmTvylPeit iNFLxTgizPqXLXa+kW9LR8ar+1goZPxU+ZggXi7ZFsf40VyJTO7S9wjLr3EnCyAsz+VN Vn7PeWbRz2D/ZzHUkGJyC6pHB5FuJGwSmKRd5xAk5eCbFHuIp+ZsGvViFMvKjNQWvm/N PESCaBUEe7QDhgHOAbde/SUS+M2B/BNjy4xAG7gkWlEU71mrTy42yj9WwGpPTUTwxWEL Y12g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=LF6PDi9hHIc/Ge1yXM0Z9pr+qeYYlpE6O6Dd716Xf/U=; b=MSUUm8fak1vwcZnaKFiL+U5HBMR0R6oLfWMT7GSmhX1ilKD3CCjyWaepMHNjoqUsA/ KV9y5YAxDHzeLR6j/IRWI8GvaVt/Yh0GImNSDGvC8ZkPBOqUo5tv+stPtcM1RDbKrBym PFdUrAnE+AyKQmN8DMDQkpLsC1Bna35Fb98TIOOhsGqRoaGlWc/o6D1B8K4HCKhkbkKO 4UFdN42dldIf2TarYleDV1VugAHiCaA3YXSZfLu5lBkCtkcGRw7wquyMP6y1TjHJbOUw XIZ29EU2fnD9zQLmExAO/23CMgyBOjQ2mE7GDmCWwRpoQvAu3qw2XcQR9GT64YQNaHeL S4EQ== X-Gm-Message-State: AOAM532X2k9AzOjuTzMC08RYMataV8gK/pmPMdQD5Q7Th/sCpFLWPsOi Q3lnWxKRzGMfLU/lU/ignZN9OymzuSjnx4xx X-Google-Smtp-Source: ABdhPJzAUQ2k7fFhdHBIwvTrBo/TyaagQ+P6YOVUE0M9yhV8fFg8+KbAdJjoPAZ9MJKiqp4Q2ZeUNw== X-Received: by 2002:a05:6214:2aaf:b0:45b:9f:8752 with SMTP id js15-20020a0562142aaf00b0045b009f8752mr7012421qvb.9.1652099892834; Mon, 09 May 2022 05:38:12 -0700 (PDT) Received: from localhost (22.b2.a86c.ip4.static.sl-reverse.com. [108.168.178.34]) by smtp.gmail.com with ESMTPSA id i22-20020ac871d6000000b002f3ad89629dsm7651907qtp.2.2022.05.09.05.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 May 2022 05:38:12 -0700 (PDT) From: Ihor Radchenko To: numbchild@gmail.com Cc: Samim Pezeshki , emacs-orgmode@gnu.org, Nicolas Goaziou Subject: [PATCH] Re: [ISSUE] Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table In-Reply-To: References: <875yqdtmb1.fsf@nicolasgoaziou.fr> Date: Mon, 09 May 2022 20:38:56 +0800 Message-ID: <877d6u3mov.fsf@localhost> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::f2f; envelope-from=yantar92@gmail.com; helo=mail-qv1-xf2f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1652100236; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LF6PDi9hHIc/Ge1yXM0Z9pr+qeYYlpE6O6Dd716Xf/U=; b=C5w96HthaqI8XVbwSmfHW3i//SpfACqMAluv4Ls8eS8dDJ4BZLeBXAkWwdxtKaQSpEaflC zcQd+u3v72WgdcjaJFXaQFl7jt0KMg3AoDoS4MInLpeLZNWF435V/yKLIKHiSNZX6+AiRp bed3EoWcTDD+8HvAKV3pyOcOqB6uoLfOtWOODev//np63QpwLgXiI4gbDLqoqAXpurjAVA yGxN1lvqfbM3ItBI0dS58IgdIL8UJOVb83z2n4d6mkuU3voadbCGhAU7yqlyEPzP7gNbYE yhxX5XyBwi30bhhnXWYQo3gyl9Vuf+TKeyeDi+ZVBUpgQF3k1URcUhfReWNxmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1652100236; a=rsa-sha256; cv=none; b=QrdE0AM6iEzpD8QJKwl12vAx1vMTU5XX/LPC7ypunW1uTizXb6LatOEiUYyBBP7tx7EkY7 5Fg8IT9bmOIbK7UDQhms0fD7+pDLP1CEj7RNS/8VbQHBTwJpboo2uG9gNVDhOffG0nv8Mv e399KCE7VBaR3TT2SjAAh80LW3Fw1xBzNaEIwqaGDVaYr3SLLDrb45mvo1cuCHr1eBNmTE 96JpTLBgDmBHNZTAu7Etu2f76lwSWfzHtSjKsmgiNCR/ixxVgEZs4GViaZXuUgFubp9kL+ qaN8yyKiPB1pVXstU82V1y6hJfLjeKzjWJsVrjTBrZNcXNrlNS/UTu4sTWib7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b+uO1hAB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -7.00 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=b+uO1hAB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DE9761BCB5 X-Spam-Score: -7.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: y43/pBuHUsgc --=-=-= Content-Type: text/plain "Christopher M. Miles" writes: > I tested this commit, it should auto append a newline character after > ~org-agenda-clock-report-header~. Otherwise the header line will in same line with table first line. Reasonable concern. The attached patch should fix it. Best, Ihor --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-org-agenda-Make-sure-that-clock-report-header-has-tr.patch >From c918d5097af4ca82e381cc7a45efccebadf22e91 Mon Sep 17 00:00:00 2001 Message-Id: From: Ihor Radchenko Date: Mon, 9 May 2022 20:35:18 +0800 Subject: [PATCH] org-agenda: Make sure that clock report header has trailing newline * lisp/org-agenda.el (org-agenda-list): Add trailing newline to `org-agenda-clock-report-header' if there is none. --- lisp/org-agenda.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 9d38b889d..3a795ef74 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -4486,8 +4486,10 @@ (defun org-agenda-list (&optional arg start-day span with-hour) (setq p (plist-put p :tend clocktable-end)) (setq p (plist-put p :scope 'agenda)) (setq tbl (apply #'org-clock-get-clocktable p)) - (when org-agenda-clock-report-header - (insert (propertize org-agenda-clock-report-header 'face 'org-agenda-structure))) + (when org-agenda-clock-report-header + (insert (propertize org-agenda-clock-report-header 'face 'org-agenda-structure)) + (unless (string-suffix-p "\n" org-agenda-clock-report-header) + (insert "\n"))) (insert tbl))) (goto-char (point-min)) (or org-agenda-multi (org-agenda-fit-window-to-buffer)) -- 2.35.1 --=-=-=--