emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: sebastien.miquel@posteo.eu
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org.el (org-format-latex-header): put DEFAULT-PACKAGES before PACKAGES
Date: Thu, 16 Jun 2022 20:19:18 +0800	[thread overview]
Message-ID: <877d5gg5rt.fsf@localhost> (raw)
In-Reply-To: <7fbcc96f-3b15-5f74-b1ff-2a2f3ed1303d@posteo.eu>

Sébastien Miquel <sebastien.miquel@posteo.eu> writes:

> Ihor Radchenko writes:
>> We actually have 2 options here:
>> 1. Change the docstring
>> 2. Change the template
>>
>> Can moving [PACKAGES] up break the existing configs? It might.
>> I am inclined to change the docstring instead.
>
> Thanks for having a look at this.
>
> It makes more sense for a package in PACKAGES to depend on a
> DEFAULT-PACKAGE than vice versa.
> ...
> I've also just checked that by default, for document export,
> DEFAULT-PACKAGES are inserted before PACKAGES --- the default
> templates from =org-latex-classes= do not include =DEFAULT-PACKAGES=
> nor =PACKAGES=, and in this case, =org-splice-latex-header= adds both
> default packages and packages at the end, with default packages coming
> first.
>
> =org-format-latex-header= is only used to generate images for preview,
> and in some cases by ob-latex to compile a document from a LaTeX src
> block.

Thanks for the clarification! Now, your patch makes much more sense. Can
you update the commit message explaining the above shortly and linking
to this thread?

Best,
Ihor


  reply	other threads:[~2022-06-16 12:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13  9:12 [PATCH] org.el (org-format-latex-header): put DEFAULT-PACKAGES before PACKAGES Sébastien Miquel
2022-06-14 13:21 ` Ihor Radchenko
2022-06-14 14:26   ` Sébastien Miquel
2022-06-16 12:19     ` Ihor Radchenko [this message]
2022-06-17 12:19       ` Sébastien Miquel
2022-06-18  4:50         ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d5gg5rt.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=sebastien.miquel@posteo.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).