emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] Erroneous link highlighting in src blocks (9.5.5-geeae6e)
@ 2022-10-07 15:46 Tim Loderhose
  2022-10-09  3:48 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Loderhose @ 2022-10-07 15:46 UTC (permalink / raw)
  To: emacs-orgmode@gnu.org

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Hi,

In recent org, org-highlight-links including 'bracket' will hide content
with double brackets inside src blocks.
A vanilla config loading 9.5.5 org (I did this through straight.el) can reproduce this with a
minimal org file including just:

#+begin_src python
[[a]]
#+end_src

The brackets will be hidden.

I can only confirm that this does not happen with org 9.5.2 - I did not
check other versions in between, but know this has been the case for a
couple of weeks at least. I don't know much of the internals, but
thought that perhaps the issue was introduced around this commit (as this touches link folding and is not included in 9.5.2):
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=67275f4664ce00b5263c75398d78816e7dc2ffa6

Cheers,
Tim

[-- Attachment #2: Type: text/html, Size: 1554 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [BUG] Erroneous link highlighting in src blocks (9.5.5-geeae6e)
  2022-10-07 15:46 [BUG] Erroneous link highlighting in src blocks (9.5.5-geeae6e) Tim Loderhose
@ 2022-10-09  3:48 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2022-10-09  3:48 UTC (permalink / raw)
  To: Tim Loderhose; +Cc: emacs-orgmode@gnu.org

Tim Loderhose <tim@loderhose.com> writes:

> Hi,
>
> In recent org, org-highlight-links including 'bracket' will hide content
> with double brackets inside src blocks.
> A vanilla config loading 9.5.5 org (I did this through straight.el) can reproduce this with a
> minimal org file including just:
>
> #+begin_src python
> [[a]]
> #+end_src
>
> The brackets will be hidden.

Thanks for reporting!

This is related to the new folding engine that broke the brittle balance
of current regexp-based Org fontification.

In general, fontification issues are numerous in Org and have to be
fixed by a complete rewrite of our fontification system. See
https://orgmode.org/list/87ee7c9quk.fsf@localhost

However, in a view of upcoming Org release, I am going to fix this
particular issue now. It is not too difficult.

Fixed on main now.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=41a409f79d07fe7a3e8c5f934b97e4a2884bf948

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-09  3:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-07 15:46 [BUG] Erroneous link highlighting in src blocks (9.5.5-geeae6e) Tim Loderhose
2022-10-09  3:48 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).