From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id uPSNJI3+lmMAkAAAbAwnHQ (envelope-from ) for ; Mon, 12 Dec 2022 11:12:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kAJxJI3+lmOJVQAA9RJhRA (envelope-from ) for ; Mon, 12 Dec 2022 11:12:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 593B1C533 for ; Mon, 12 Dec 2022 11:12:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4fmh-0003XE-GU; Mon, 12 Dec 2022 05:11:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fme-0003WP-Io for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 05:11:40 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4fmc-0006CU-Cm for emacs-orgmode@gnu.org; Mon, 12 Dec 2022 05:11:40 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4A833240027 for ; Mon, 12 Dec 2022 11:11:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670839896; bh=9XgZEO6Izcu421piDWy6xe0djR3XxYE3YtPXb5TzbKc=; h=From:To:Cc:Subject:Date:From; b=S/ARfL1Hz79RBrr59KV8Supb3Oqxtezv1M6CRV4uigQw2tOVnX9PW5txTFszt2Cun fCvMZMsejRGUKoQQOANF71/apeKxI3TuIEJFldd11QfI8H7RRD8yPDRVfPS4cuaSbq Ib8C98ApyhUn8+SilgAtfhYMKMuYYUvWHCPFosw9rqt5quh/b9SO2PxWlZcov5J9nL u4h5V/adviHFRQUeoNwBHY8Ddy8qmo2+kzZIvUrRK6kdmkfmvNF0PCQEYNBYp5GYO9 SAFnyzGUV3AiPA4zHdaWeSZEPDkU7sv3LNDdS3q/vBUvZTPfcaEQ2yMarFdCsIshZ8 RrCXitTOWexog== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NVy8R3cc3z9rxH; Mon, 12 Dec 2022 11:11:35 +0100 (CET) From: Ihor Radchenko To: Pedro Andres Aranda Gutierrez Cc: Org Mode List Subject: Re: PATCH: include controlling language= in my previous patch In-Reply-To: References: <87cz8qdzmy.fsf@localhost> Date: Mon, 12 Dec 2022 10:11:34 +0000 Message-ID: <877cyxhqy1.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670839949; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=FXxlQ9WPI0dTns8rB3JjO+1712WB5Hdlbk1xWBgB+so=; b=nRdHHRXljKRtk1OuTYa4kUWj1x3dOuBaPjzhlYPi0jvB1uOjla8Nosfzj+1kf9xKHWCcjM Lf0y3b2bqtFKLh8hDPuiqJjpIHDeUJ5eNGQLX9j11V2pjBxlTqpP+wQKszxz9iEnLe8XIS Ur/AImzG8lmPjTcyga4jMdNBDEQCNAdWNPNveVm7jIVMUenu4Wp+Z/5RLIr6NrbFb4FYG7 ooENb9YtSbIGaTX37/LVw5QlBXQN+1u0/Q4w7gd1BDZMdVDjerKbfbLCE25vcdm6JYWljm ZM4xYnyRprlljgOFP0mYwdsrblrltKUbIcuSN2GFUWS8mpz3Np+ndQqFWLV8Tg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="S/ARfL1H"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670839949; a=rsa-sha256; cv=none; b=D6nVl7Ilhs6G4M7MSZuCx9BNvZIkMrj4A/c1ZtEL8dqAdJFvu4TrVPBd0sMfnZgv2MrH+K Gbup+fY6wvejgVJ7EQxWBP73sVn/VLL1iPOs6gc5zZFRJ4cfBPvLziBPkQeil10rfpLxZy OX/9tlzMm6MGKROi5zgu5wwoZS4AkXZPn8R25U5zF8lzI4gOU4w4UyP8ij9fulgV3EbmE6 PXc6vEy8NbFbnpoZJqNiyyCo2m1P5rvWSl0pZgmkwYtcznSqPgigzghkhM0j7+FWNSTb2S L/8X+WoG67N19z1wjuA17B3+ZZnX50bTKZ0yZhJDHyZxFSw3PBPVABgYYjJy+Q== X-Migadu-Spam-Score: -5.75 X-Spam-Score: -5.75 X-Migadu-Queue-Id: 593B1C533 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="S/ARfL1H"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: JFlDAlFJHaR2 Pedro Andres Aranda Gutierrez writes: > thanks for the patience. I have a comment on the message you refer to... = If > comes from 2014. > > So I have resorted to my fresh Emacs29, opened it with emacs -Q for a cle= an > environment. > ... > In my most humble opinion, I looks like the global \lstset{} isn't used a= nd > that the caption/label is set locally. And this makes me believe that > label=3D or caption=3D are not very useful. I guess it is after https://git.savannah.gnu.org/cgit/emacs/org-mode.git/co= mmit/?id=3D6ef33b6dd If the cited issue is no longer need to be accounted for, your version should be fine. > I'm attaching the patch generated with git diff -p. > Mea culpa, I should have RTFM before sending anything :-) For the final version of the patch, you may better follow https://orgmode.org/worg/org-contribute.html#orgbc683f3 to create a .patch file. The .patch file will include your authorship. Do not forget the changelog entry. > +(defcustom org-latex-listings-src-omit-language nil > + "Set this option to t to omit the > +\"language=3D\" > +in the parameters to \\begin{lstlisting} when exporting a src block" > + :group 'org-export-latex > + :version "30.0" > + :package-version '(Org . "9.7") > + :type 'boolean > + ) Please do not leave handing ")" on separate lines. It is against common Elisp style conventions. See D.1 Emacs Lisp Coding Conventions section of Elisp manual: =E2=80=A2 Don=E2=80=99t make a habit of putting close-parentheses on lin= es by themselves; Lisp programmers find this disconcerting. > + (when label ; label=3D w/o label makes littl= e sense > + `(("label" ,(org-latex--label src-block info)))) > + (when caption-str ; caption=3D w/o caption makes l= ittle sense > + `(("caption" ,caption-str)) > + `(("captionpos" ,(if caption-above-p "t" "b")))) ; as does ca= ptionpos w/o caption These comments are not really needed. Actually, it is that `if' that deserved explanation. Not putting empty caption/label is intuitive. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at