From: Ihor Radchenko <yantar92@posteo.net>
To: Samuel Wales <samologist@gmail.com>
Cc: Max Nikulin <manikulin@gmail.com>, emacs-orgmode@gnu.org
Subject: Improve org-insert-link completion (was: [Bug] org-insert-link removes on one link from 2 added by org-store-link)
Date: Thu, 13 Jul 2023 10:46:41 +0000 [thread overview]
Message-ID: <877cr4ytpq.fsf@localhost> (raw)
In-Reply-To: <CAJcAo8vq1LRERv0S5SZFwRsp-MVm4uLNnkXH7jJ43wLk-EAwXA@mail.gmail.com>
Samuel Wales <samologist@gmail.com> writes:
> link has already been stored is a bug in my case in that i can't just
> go to a header, grab it [whether rabbed bfere or not] and then paste
> it. i surprise easily when the wrong link gets pasted.
This has been fixed already.
> in answer to a q by ihor, indeed puttig previously stored id liks as
> descriptions in front of all the prefixes woudl be useful to me, but
> idk who is doing the sorting, so idk whether it wold make a difference
> but if it dos then gret..]
Org is actually not supposed to control sorting. It is to be customized
by user via `completions-sort'.
What we can do instead is provide grouping metadata.
Below, I provide a simple demo on how it looks like.
However, the demo will only make a difference starting from Emacs 28
that has the necessary completion API.
(defun org--complete-links (string predicate flag)
(let* ((links '(:type ("id:" "file:") :path ("/a/a/b" "file.org") :description ("foo" "barr" "baz")))
(all-links (append (plist-get links :type) (plist-get links :path) (plist-get links :description)))
matches)
(pcase flag
(`nil (try-completion string all-links predicate))
(`t (all-completions string all-links predicate))
(`lambda (test-completion string all-links predicate))
(`(boundaries . suffix) (completion-boundaries string all-links predicate suffix))
(`metadata
`(metadata
(group-function
.
(lambda (completion transform)
(if transform completion
(let ((links ',links))
(cond
((member completion (plist-get links :type)) "Link type")
((member completion (plist-get links :path)) "Link path")
((member completion (plist-get links :description)) "Link description")))))))))))
(completing-read "Test: " #'org--complete-links)
> it seems org-insert-=inki is overloaded. one use case says insert a
> previously stored link. the other says insert a brand new link which
> i will now specify. might it be useful to separate those two
> functions?
I do not see why it is overloaded. The last stored link is used as
default completion option, which is a common practice.
You can also use C-u 1 C-c C-M-l to insert the last stored link.
Or just C-c C-M-l.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-07-13 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 6:08 [Bug] org-insert-link removes on one link from 2 added by org-store-link Max Nikulin
2023-07-02 7:49 ` Ihor Radchenko
2023-07-12 12:12 ` Max Nikulin
2023-07-13 3:34 ` Samuel Wales
2023-07-13 10:46 ` Ihor Radchenko [this message]
2023-07-23 10:39 ` Max Nikulin
2023-07-24 1:06 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cr4ytpq.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=manikulin@gmail.com \
--cc=samologist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).