From: Ihor Radchenko <yantar92@posteo.net>
To: Leo Butler <Leo.Butler@umanitoba.ca>
Cc: Ihor Radchenko <yantar92@gmail.com>,
Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: [BUG] beamer export
Date: Mon, 19 Feb 2024 09:42:08 +0000 [thread overview]
Message-ID: <877cj0hjtb.fsf@localhost> (raw)
In-Reply-To: <87mss3ja6i.fsf@t14.reltub.ca>
Leo Butler <Leo.Butler@umanitoba.ca> writes:
>> What about not adding BEAMER_FRAME, but instead adding org-lint checker
>> that will detect when frame text contains the problematic \end{orgframe}?
>
> Ok, thanks for your feedback. I have modified the patch along the lines
> you suggested. It is attached.
Thanks!
It looks like you left over some parts from the previous patch version.
> (org-beamer--format-frame): Introduce the new property, :BEAMER_FRAME.
... like this.
> (org-beamer--frame-environments): New variable and function. The
> variable holds a list of names of frame environments found while
> formatting frames. The function generates the LaTeX code to define
> each new frame environment.
> (org-beamer-template): Add a call to `org-beamer--frame-environments'
> to insert the environment definitions into the beamer document.
And since we only have a single alternative environment in this version
of the patch, `org-beamer--frame-environments' does not appear to be
necessary.
> +(defcustom org-beamer-frame-environment "orgframe"
> + "Name of the beamer frame environment."
> + :group 'org-export-beamer
> + :type '(string :tag "Beamer frame"))
It would be nice to provide a mode detailed explanation about the
purpose of this custom option.
> +(defun org-lint-beamer-frame (ast)
> + "Check for occurrences of begin or end frame."
> + (org-with-point-at ast
> + (goto-char (point-min))
> + (let (result)
> + (while (re-search-forward
> + (concat "\\\\\\(begin\\|end\\){" org-beamer-frame-environment "}") nil t)
> + (push (list (match-beginning 0) "Beamer frame name may cause error when exporting.") result))
> + result)))
... and to link this org-lint warning to the
`org-beamer-frame-environment' docstring.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2024-02-19 9:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 19:46 [BUG] beamer export Leo Butler
2022-09-29 2:45 ` Ihor Radchenko
2022-09-29 18:43 ` Daniel Fleischer
2022-12-10 12:49 ` Ihor Radchenko
2024-01-20 14:56 ` Ihor Radchenko
2024-01-23 16:58 ` Leo Butler
2024-01-24 16:06 ` Ihor Radchenko
2024-01-25 16:13 ` Leo Butler
2024-01-26 11:45 ` Ihor Radchenko
2024-01-26 20:54 ` Leo Butler
2024-01-29 21:36 ` Leo Butler
2024-02-01 15:04 ` Ihor Radchenko
2024-02-14 16:13 ` Leo Butler
2024-02-19 9:42 ` Ihor Radchenko [this message]
2024-02-20 20:41 ` Leo Butler
2024-02-21 10:51 ` Ihor Radchenko
2024-01-25 22:29 ` Leo Butler
2024-01-26 13:30 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cj0hjtb.fsf@localhost \
--to=yantar92@posteo.net \
--cc=Leo.Butler@umanitoba.ca \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).