emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)]
@ 2024-06-09 20:08 Johann Klähn
  2024-06-14 13:05 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Johann Klähn @ 2024-06-09 20:08 UTC (permalink / raw)
  To: emacs-orgmode


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

When I drag a file onto a buffer and use `?' at the resulting
`read-multiple-choice' prompt to open the help buffer,
a `(wrong-type-argument char-or-string-p attach)' error occurs.
Ultimately, `org--dnd-local-file-handler' passes a symbol where
`read-multiple-choice' expects a “description” string: the optional
third entry of each “choice”.  Cf. the documentation string of 
`read-multiple-choice':

> CHOICES should be a list of the form (KEY NAME [DESCRIPTION]).
> KEY is a character the user should type to select the entry.
> NAME is a short name for the entry to be displayed while prompting
> (if there’s no room, it might be shortened).
> DESCRIPTION is an optional longer description of the entry; it will
> be displayed in a help buffer if the user requests more help.

I hope that helps.
Thanks for the useful feature and the great 9.7 release. 🙃

Emacs  : GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)
 of 2024-06-04
Package: Org mode version 9.7.2 (release_9.7.2-8-gde0df5)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)]
@ 2024-06-10 12:21 Johann Klähn
  2024-06-14 13:07 ` Ihor Radchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Johann Klähn @ 2024-06-10 12:21 UTC (permalink / raw)
  To: emacs-orgmode


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

When I drag a file onto a buffer and use `?' at the resulting
`read-multiple-choice' prompt to open the help buffer,
a `(wrong-type-argument char-or-string-p attach)' error occurs.
Ultimately, `org--dnd-local-file-handler' passes a symbol where
`read-multiple-choice' expects a “description” string: the optional
third entry of each “choice”.  Cf. the documentation string of 
`read-multiple-choice':

> CHOICES should be a list of the form (KEY NAME [DESCRIPTION]).
> KEY is a character the user should type to select the entry.
> NAME is a short name for the entry to be displayed while prompting
> (if there’s no room, it might be shortened).
> DESCRIPTION is an optional longer description of the entry; it will
> be displayed in a help buffer if the user requests more help.

I hope that helps.
Thanks for the useful feature and the great 9.7 release. 🙃

Emacs  : GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0)
 of 2024-06-04
Package: Org mode version 9.7.2 (release_9.7.2-8-gde0df5)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)]
  2024-06-09 20:08 Johann Klähn
@ 2024-06-14 13:05 ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-06-14 13:05 UTC (permalink / raw)
  To: Johann Klähn; +Cc: emacs-orgmode

Johann Klähn <org-mode@web.jklaehn.de> writes:

> When I drag a file onto a buffer and use `?' at the resulting
> `read-multiple-choice' prompt to open the help buffer,
> a `(wrong-type-argument char-or-string-p attach)' error occurs.
> Ultimately, `org--dnd-local-file-handler' passes a symbol where
> `read-multiple-choice' expects a “description” string: the optional
> third entry of each “choice”.  Cf. the documentation string of 
> `read-multiple-choice':
>
>> CHOICES should be a list of the form (KEY NAME [DESCRIPTION]).
>> KEY is a character the user should type to select the entry.
>> NAME is a short name for the entry to be displayed while prompting
>> (if there’s no room, it might be shortened).
>> DESCRIPTION is an optional longer description of the entry; it will
>> be displayed in a help buffer if the user requests more help.
>
> I hope that helps.
> Thanks for the useful feature and the great 9.7 release. 🙃

Thanks for reporting!
Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=2347eac66

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)]
  2024-06-10 12:21 [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)] Johann Klähn
@ 2024-06-14 13:07 ` Ihor Radchenko
  0 siblings, 0 replies; 4+ messages in thread
From: Ihor Radchenko @ 2024-06-14 13:07 UTC (permalink / raw)
  To: Johann Klähn; +Cc: emacs-orgmode

Johann Klähn <org-mode@web.jklaehn.de> writes:

> When I drag a file onto a buffer and use `?' at the resulting
> `read-multiple-choice' prompt to open the help buffer,
> a `(wrong-type-argument char-or-string-p attach)' error occurs.
> Ultimately, `org--dnd-local-file-handler' passes a symbol where
> `read-multiple-choice' expects a “description” string: the optional
> third entry of each “choice”.  Cf. the documentation string of 
> `read-multiple-choice':

Duplicate of https://list.orgmode.org/orgmode/87ikyhg9qi.fsf@jklaehn.de/
Canceled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-06-14 13:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-10 12:21 [BUG] Broken read-multiple-choice help in DND local file handler [9.7.2 (release_9.7.2-8-gde0df5)] Johann Klähn
2024-06-14 13:07 ` Ihor Radchenko
  -- strict thread matches above, loose matches on Subject: below --
2024-06-09 20:08 Johann Klähn
2024-06-14 13:05 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).