From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: Org Remember hooks? Date: Wed, 19 Nov 2008 08:19:18 -0500 Message-ID: <8763mjrgyx.fsf@gollum.intra.norang.ca> References: <3d6808890811180918l1c9f1eafof77ef38aa7dd3bb@mail.gmail.com> <857E0F97-90FB-42EC-A996-E98065B4D25B@uva.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L2mxq-0001if-4o for emacs-orgmode@gnu.org; Wed, 19 Nov 2008 08:19:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L2mxp-0001hk-GA for emacs-orgmode@gnu.org; Wed, 19 Nov 2008 08:19:25 -0500 Received: from [199.232.76.173] (port=55068 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L2mxp-0001hY-2a for emacs-orgmode@gnu.org; Wed, 19 Nov 2008 08:19:25 -0500 Received: from mho-02-bos.mailhop.org ([63.208.196.179]:49561) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L2mxo-0000wg-PW for emacs-orgmode@gnu.org; Wed, 19 Nov 2008 08:19:24 -0500 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: Tim O'Callaghan , org-mode Hi Carsten, Remember mode seems to be broken this morning. After entering my remember note C-c C-c gives the following error Debugger entered--Lisp error: (wrong-type-argument commandp org-remember-finalize) call-interactively(org-remember-finalize) According to git bisect the following commit breaks it ------------------------------------------------------------------------ fb22510c1c66af3fdfea1b63d09f358e9914a3d3 is first bad commit commit fb22510c1c66af3fdfea1b63d09f358e9914a3d3 Author: Carsten Dominik Date: Wed Nov 19 11:49:17 2008 +0100 Use the new minor mode to exit remember buffers. Since we have now a minor mode in remember buffers, we use its keymap also to exit and to abort the remember process. :040000 040000 657feade3fc36b41315bc7db7b850b1319f74e51 37a5014d08cfb38839dfa1c9778ad67f599f4c34 M lisp ------------------------------------------------------------------------ -Bernt Carsten Dominik writes: > Hi Tim, > > On Nov 18, 2008, at 6:18 PM, Tim O'Callaghan wrote: > >> Hi, >> >> I want to change/add to the remember mode key-map but i'm having some >> problems reverting them. >> That's because the remember buffer is actually org-mode in disguise, >> the keys stay mapped after the remember mode buffer is closed. >> >> Is it possible to localise the org-remember mappings, or supply a post >> org-remember hook? > > These are both good ideas. You are right that it is bad that it is so > difficult to change key bindings in Org's version of remember-mode. > But I think it makes a lot of sense to have the remember buffer > in Org-mode with all its power. > > Here is what I have done now: > > 1. Finishing a remember process runs `org-remember-before-finalize- > hook'. > You could use this to revert your bindings, but the following > second option is better: > > 2. I have defined a *minor* mode, org-remember-mode with lighter "Rem" > that is activated when Org-mode is active in a remember buffer. > You can use its hook `org-remember-mode-hook' or also > `remember-mode-hook' to install your keys into `org-remember-mode- > map'. > It will *not* be necessary to turn off these keys, so for this > purpose > you will actually not need `org-remember-before-finalize-hook', > which may > find other uses. > > This should work (untested): > > (defun toc:remap-remember-keys () > (define-key org-remember-mode-map [(control x) (control s)] > remember-finalize) > (define-key org-remember-mode-map [(meta k)] > remember-destroy)) > (add-hook 'org-remember-mode-hook 'toc:remap-remember-keys 'append) > > > HTH > > - Carsten > > > _______________________________________________ > Emacs-orgmode mailing list > Remember: use `Reply All' to send replies to the list. > Emacs-orgmode@gnu.org > http://lists.gnu.org/mailman/listinfo/emacs-orgmode