emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tassilo@member.fsf.org>
To: emacs-orgmode@gnu.org
Subject: Re: Problem with org-gnus-follow-link
Date: Tue, 09 Dec 2008 17:58:53 +0100	[thread overview]
Message-ID: <8763lt8euq.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: zf.upnk5a9o7sz.fsf@zeitform.de

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

Ulf Stegemann <ulf-news@zeitform.de> writes:

Hi Ulf,

> After a bit of investigation I found out that the problem is
> `gnus-group-read-group' which is called by `org-gnus-follow-link'.
> `gnus-group-read-group' does not return an article but nil if the last
> message of the group has been deleted (this is re-producable here).

Not really.  But it won't open the Summary buffer if the last article
was deleted.

Please try this patch and report back if it works.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: foo.patch --]
[-- Type: text/x-patch, Size: 1166 bytes --]

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 1058b0d..5adfd7e 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -144,6 +144,7 @@ If `org-store-link' was called with a prefix arg the meaning of
 
 (defun org-gnus-open (path)
   "Follow the Gnus message or folder link specified by PATH."
+  (setq path (substring-no-properties path))
   (let (group article)
     (if (not (string-match "\\`\\([^#]+\\)\\(#\\(.*\\)\\)?" path))
 	(error "Error in Gnus link"))
@@ -157,13 +158,9 @@ If `org-store-link' was called with a prefix arg the meaning of
   (funcall (cdr (assq 'gnus org-link-frame-setup)))
   (if gnus-other-frame-object (select-frame gnus-other-frame-object))
   (cond ((and group article)
-	 (gnus-group-read-group 1 nil group)
-	 (gnus-summary-goto-article
-	  (if (string-match "[^0-9]" article)
-	      article
-	    (string-to-number article))
-	  nil t))
-	(group (gnus-group-jump-to-group group))))
+         (gnus-group-read-group t nil group)
+         (gnus-summary-goto-article article nil t))
+        (group (gnus-group-jump-to-group group))))
 
 (defun org-gnus-no-new-news ()
   "Like `M-x gnus' but doesn't check for new news."

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


Bye,
Tassilo

[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

  reply	other threads:[~2008-12-09 16:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-09 12:24 Problem with org-gnus-follow-link Ulf Stegemann
2008-12-09 16:58 ` Tassilo Horn [this message]
2008-12-10 10:08   ` Ulf Stegemann
2008-12-10 19:08     ` Tassilo Horn
2008-12-11 10:09       ` Ulf Stegemann
2008-12-11 11:02         ` Tassilo Horn
2008-12-11 13:52           ` Ulf Stegemann
2008-12-11 14:16             ` Tassilo Horn
2008-12-11 15:37               ` Ulf Stegemann
2008-12-11 15:56                 ` Tassilo Horn
2008-12-11 16:18                   ` Ulf Stegemann
2008-12-11 16:41                     ` Tassilo Horn
2008-12-11 18:17                     ` Tassilo Horn
2008-12-11 21:51                       ` Ulf Stegemann
2008-12-12  7:04                         ` Tassilo Horn
2008-12-12  8:17                           ` Ulf Stegemann
2008-12-12 10:31                             ` Tassilo Horn
2008-12-12 14:21                               ` Ulf Stegemann
2008-12-11  8:15     ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763lt8euq.fsf@thinkpad.tsdh.de \
    --to=tassilo@member.fsf.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).