From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernt Hansen Subject: Re: Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] Date: Mon, 17 Jan 2011 11:47:10 -0500 Message-ID: <8762tnjx4h.fsf@norang.ca> References: <87ei9a30tx.fsf@norang.ca> <87k4j2e1bb.fsf@noorul.maa.corp.collab.net> <87y67i0z5c.fsf@norang.ca> <87zkr3h3qv.fsf@norang.ca> <257A79BB-86AC-43E5-AE9D-132168283FFB@gmail.com> <87k4i7gz5a.fsf@norang.ca> <8739ord2r4.fsf@norang.ca> <97009C4F-F6B7-4C54-BF3C-B3DE5EF15547@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from [140.186.70.92] (port=58029 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PesEd-0000yC-Cs for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 11:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PesEc-0006OA-5C for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 11:47:15 -0500 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:12193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PesEc-0006O0-2J for emacs-orgmode@gnu.org; Mon, 17 Jan 2011 11:47:14 -0500 In-Reply-To: (Julien Danjou's message of "Mon, 17 Jan 2011 16:08:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Julien Danjou Cc: Org Mode , Noorul Islam K M , Carsten Dominik Julien Danjou writes: > On Mon, Jan 17 2011, Carsten Dominik wrote: > >> have you been following this thread? I think this has to do with your >> rewrite of the dagenda span stuff. Maybe you can find out better and >> faster that I why this goes wrong? Please read the entire thread. > > I've followed but not sure I understood what the bug is. But from my > various tries, I found a bug: when pressing 'j', the current span is > discarded. > > Attached is a patch that should fix that, even for future use of > `org-agenda-list' with the span unspecified. :) Hi Julien, Thanks for this patch. I think this fixes the issue I was having with 'j' in the agenda switching from week-view back to single-day view when org-agenda-ndays is set to 1. There is still a (new?) problem with jumping to today. Set the following variable (setq org-agenda-start-on-weekday 6) | Key Sequence | Notes | |--------------+------------------------------------------------| | C-c a a | Display weekly agenda | | f | Go forward a week | | d | Display day agenda | | . | Go to to day - but it goes to Saturday instead | This should go to today and not the first day of the week. Regards, Bernt > > > From 9dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001 > From: Julien Danjou > Date: Mon, 17 Jan 2011 16:05:28 +0100 > Subject: [PATCH] Fix agenda span on date jump > > * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a > possible default span if it is set. > > Signed-off-by: Julien Danjou > --- > lisp/org-agenda.el | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el > index 0cd620c..0d695b5 100644 > --- a/lisp/org-agenda.el > +++ b/lisp/org-agenda.el > @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'." > (setq org-agenda-last-arguments (list include-all start-day span)) > (org-compile-prefix-format 'agenda) > (org-set-sorting-strategy 'agenda) > - (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays org-agenda-span))) > + (let* ((span (org-agenda-ndays-to-span (or span > + org-agenda-current-span > + org-agenda-ndays > + org-agenda-span))) > (today (org-today)) > (sd (or start-day today)) > (ndays (org-agenda-span-to-ndays span sd)) > -- > 1.7.2.3