* Bug: org-store-link only works interactively [7.4]
@ 2010-12-20 8:51 Dave Abrahams
2011-02-11 9:57 ` Bastien
0 siblings, 1 reply; 2+ messages in thread
From: Dave Abrahams @ 2010-12-20 8:51 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
Because of this stanza at the end of org-store-link:
(if (and (or (interactive-p) executing-kbd-macro) link)
(progn
(setq org-stored-links
(cons (list link desc) org-stored-links))
(message "Stored: %s" (or desc link))
(when custom-id
(setq link (concat "file:" (abbreviate-file-name (buffer-file-name))
"::#" custom-id))
(setq org-stored-links
(cons (list link desc) org-stored-links))))
(or agenda-link (and link (org-make-link-string link desc))))))
org-stored-links will only be updated if the function is called
interactively. I'm not sure why you would want to neuter
org-store-link otherwise, but the docs for interactive-p say:
The only known proper use of `interactive-p' is in deciding whether to
display a helpful message, or how to display it. If you're thinking
of using it for any other purpose, it is quite likely that you're
making a mistake.
Granted, it also says:
Think: what do you want to do when the command is called from a
keyboard macro?
and you handle that particular case explicitly. However, there are
other reasons not to write functions this way (namely, someone like me
will want to store a link programmatically, and will then have to
spend a long time debugging to discover why it doesn't work).
Emacs : GNU Emacs 23.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.29)
of 2010-05-08 on black.local
Package: Org-mode version 7.4
--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Bug: org-store-link only works interactively [7.4]
2010-12-20 8:51 Bug: org-store-link only works interactively [7.4] Dave Abrahams
@ 2011-02-11 9:57 ` Bastien
0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2011-02-11 9:57 UTC (permalink / raw)
To: Dave Abrahams; +Cc: emacs-orgmode
Hi Dave,
Dave Abrahams <dave@boostpro.com> writes:
> org-stored-links will only be updated if the function is called
> interactively. I'm not sure why you would want to neuter
> org-store-link otherwise, but the docs for interactive-p say:
>
> The only known proper use of `interactive-p' is in deciding whether to
> display a helpful message, or how to display it. If you're thinking
> of using it for any other purpose, it is quite likely that you're
> making a mistake.
True, thanks for pointing at this. I agree the user should be able to
call org-store-link non-interactively (programmatically).
Carsten, I see no possible side-effects, but perhaps you had a good
reason for preventing non-interactive calls to `org-store-link'?
Thanks,
--
Bastien
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-11 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-20 8:51 Bug: org-store-link only works interactively [7.4] Dave Abrahams
2011-02-11 9:57 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).