emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Christian Egli <christian.egli@sbs.ch>
To: emacs-orgmode@gnu.org
Subject: Re: [taskjuggler] small edits to org-taskjuggler.el for tj3
Date: Tue, 05 Apr 2011 10:58:00 +0200	[thread overview]
Message-ID: <8762qtnkh3.fsf@sbs.ch> (raw)
In-Reply-To: 87fwpxnnx8.fsf@sbs.ch

Christian Egli <christian.egli@sbs.ch> writes:

>> * in org-taskjuggler-open-project, the duration is never calculated
>> (default is always used).
>
> Good catch and thanks for your patch. Unfortunately the patch causes
> problems with my export. The duration is now correctly calculated,
> however the root task now also has an end attribute which causes
> problems down the road and TJ2 tells me that "End of task foo does not
> fit into the project time frame. Try using a later project end date".
> But no matter how much I put the end date into the future the issue
> remains. If I remove the end attribute from the root task it seems to
> work. 

The following patch seems to work. If you're OK with it I will commit.

diff --git a/lisp/org-taskjuggler.el b/lisp/org-taskjuggler.el
index f891634..20bd91f 100644
--- a/lisp/org-taskjuggler.el
+++ b/lisp/org-taskjuggler.el
@@ -553,11 +553,11 @@ specified it is calculated
 	(headline (cdr (assoc "headline" project)))
 	(version (cdr (assoc "version" project)))
 	(start (cdr (assoc "start" project)))
-	(end (cdr (assoc "end" project))))
+	(period (or (cdr (assoc "period" project))
+		    (format "%s +%sd" start org-export-taskjuggler-default-project-duration))))
     (insert
-     (format "project %s \"%s\" \"%s\" %s +%sd {\n }\n"
-	     unique-id headline version start
-	     org-export-taskjuggler-default-project-duration))))
+     (format "project %s \"%s\" \"%s\" %s {\n }\n"
+	     unique-id headline version period))))
 
 (defun org-taskjuggler-filter-and-join (items)
   "Filter all nil elements from ITEMS and join the remaining ones

Thanks
Christian
-- 
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland

     prev parent reply	other threads:[~2011-04-05  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 19:58 [taskjuggler] small edits to org-taskjuggler.el for tj3 Sullivan, Gregory (US SSA)
2011-04-05  7:43 ` Christian Egli
2011-04-05  8:58   ` Christian Egli [this message]

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:f891634 dfblob:20bd91f
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8762qtnkh3.fsf@sbs.ch \
    --to=christian.egli@sbs.ch \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).