From: Nicolas Goaziou <n.goaziou@gmail.com>
To: "Дядов Васил Стоянов" <vdyadov@elvees.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: [PATCH] Org-babel: separate #+attr_... for code block and for results block [7.9.3d (release_7.9.3d-834-g60083a.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)]
Date: Thu, 24 Jan 2013 14:20:04 +0100 [thread overview]
Message-ID: <87622mbtvf.fsf@gmail.com> (raw)
In-Reply-To: <s4ysj5rovvq.fsf@canopus-pc.elvees.com> ("Дядов Васил Стоянов"'s message of "Thu, 24 Jan 2013 11:58:17 +0400")
Hello,
vdyadov@elvees.com (Дядов Васил Стоянов) writes:
> With my patch to ob-core.el org-babel works fine with your suggestion. It
> just skips #+attr_...: lines as blank lines (original behaviour of
> org-babel is to skip blank lines between #+end_src and #+results, when
> it searches results block for updating).
My remark about syntax was orthogonal to your patch. I was just pointing
out you used a wrong example. Eric Schulte will know better than me
about your patch.
> Of course, org-babel behavior may be easily changed to dissallow empty
> lines between #+attr_...: and #+results:.
It would be better, indeed.
> But currently org-elements allows next construction:
>
> ,----
> | #+attr_html: alt="big image" width="100%"
> | ^
> | |
> | +- several empty lines between attr and file
> | |
> | v
> | file:123.png
> `----
Of course not. With:
#+attr_html: alt="big image" width="100%"
file:123.png
(org-element-property :attr_html (org-element-at-point)) with point at
"file:..." will return ("alt=\"big image\" width=\"100%\"") while on the
following example:
#+attr_html: alt="big image" width="100%"
file:123.png
it will return nil.
> That is why I think that it is not necessary to make org-babel behavior
> different from org-elements (to dissalow empty lines between #+attr and
> #+results when it searches results block), at least for now.
Babel behaviour is already slightly different from Elements's. In the
long run it will be necessary to correct this.
> PS: Is there any good documentation and explanation of org-mode
> internals? I could help a little with rewritting org-babel to use
> org-elements.
You may have a look at the comments at the start of org-elements.el. At
some point, I will have to write an Info doc about this library, unless
I postpone it until the end of time.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2013-01-24 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 11:43 Bug: [PATCH] Org-babel: separate #+attr_... for code block and for results block [7.9.3d (release_7.9.3d-834-g60083a.dirty @ /home/vdyadov/Work/Tools/emacs/org-mode/lisp/)] Дядов Васил Стоянов
2013-01-23 13:15 ` Nicolas Goaziou
2013-01-23 15:03 ` Дядов Васил Стоянов
2013-01-23 15:22 ` Nicolas Goaziou
2013-01-24 7:58 ` Дядов Васил Стоянов
2013-01-24 7:59 ` Bastien
2013-01-24 13:20 ` Nicolas Goaziou [this message]
2013-01-24 14:10 ` Дядов Васил Стоянов
2013-01-24 14:13 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87622mbtvf.fsf@gmail.com \
--to=n.goaziou@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=vdyadov@elvees.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).