emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Peter Münster" <pmlists@free.fr>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] org-notify: Fix compatibility with latest org-element (uppercase properties)
Date: Thu, 27 Jun 2013 18:41:59 +0200	[thread overview]
Message-ID: <8761wzbj54.fsf@micropit.couberia.selfip.net> (raw)
In-Reply-To: 87li5voarm.fsf@bzg.ath.cx

On Thu, Jun 27 2013, Bastien wrote:

>> * contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
>> org-element are all uppercase now.
>
> Mhh... not sure what it means -- do you have a pointer?

Yes, here: http://article.gmane.org/gmane.emacs.orgmode/73628

Citation:

  | (defun org-element-headline-parser (limit &optional raw-secondary-p)
  |   "Parse a headline.
  |
  | Return a list whose CAR is `headline' and CDR is a plist
  | containing `:raw-value', `:title', `:alt-title', `:begin',
  | `:end', `:pre-blank', `:hiddenp', `:contents-begin' and
  | `:contents-end', `:level', `:priority', `:tags',
  | `:todo-keyword',`:todo-type', `:scheduled', `:deadline',
  | `:closed', `:quotedp', `:archivedp', `:commentedp' and
  | `:footnote-section-p' keywords.
  |
  | The plist also contains any property set in the property drawer,
  | with its name in upper cases and colons added at the
  | beginning (i.e. `:CUSTOM_ID').
  |
        [...]


>> -    (let* ((list (nth 1 heading))      (notify (or (get :notify) "default"))
>> +    (let* ((list (nth 1 heading))      (notify (or (get :NOTIFY) "default"))
>
> I feel dull: please let me know why this is needed.

No problem. Here another pointer:
http://article.gmane.org/gmane.emacs.orgmode/73637

-- 
           Peter

  reply	other threads:[~2013-06-27 16:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 20:22 [PATCH 1/2] org-notify: Don't use obsolete flet and macrolet Peter Münster
2013-06-18 20:22 ` [PATCH 2/2] org-notify: Fix compatibility with latest org-element (uppercase properties) Peter Münster
2013-06-27 14:42   ` Bastien
2013-06-27 16:41     ` Peter Münster [this message]
2013-06-18 21:11 ` [PATCH 1/2] org-notify: Don't use obsolete flet and macrolet David Engster
2013-06-18 23:03   ` Peter Münster
2013-06-19 17:14     ` Achim Gratz
2013-06-19 18:46       ` David Engster
2013-06-20  9:51         ` Carsten Dominik
2013-06-20 11:52           ` Peter Münster
2013-08-31  6:32             ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761wzbj54.fsf@micropit.couberia.selfip.net \
    --to=pmlists@free.fr \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).