From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] ox-html: Restore wrongly omitted table attributes under
 HTML5.
Date: Sun, 30 Jun 2013 00:37:33 +0200
Message-ID: <8761wwk0gi.fsf@gmail.com>
References: <51CEF804.8070608@arfer.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Ut3lk-0003QX-5F
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 18:37:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Ut3li-0007aq-EF
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 18:37:24 -0400
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:56985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1Ut3li-0007aZ-7W
	for emacs-orgmode@gnu.org; Sat, 29 Jun 2013 18:37:22 -0400
Received: by mail-wi0-f169.google.com with SMTP id c10so2941768wiw.4
	for <emacs-orgmode@gnu.org>; Sat, 29 Jun 2013 15:37:21 -0700 (PDT)
In-Reply-To: <51CEF804.8070608@arfer.net> (Kodi Arfer's message of "Sat, 29
	Jun 2013 11:06:44 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Kodi Arfer <kodi@arfer.net>
Cc: emacs-orgmode@gnu.org

Hello,

Kodi Arfer <kodi@arfer.net> writes:

> From edd97671641e28c3e240efe6ea8fa8d77b4b7eae Mon Sep 17 00:00:00 2001
> From: Kodi Arfer <git@arfer.net>
> Date: Sat, 29 Jun 2013 10:43:07 -0400
> Subject: [PATCH] ox-html: Restore wrongly omitted table attributes under
>  HTML5.
>
> * lisp/ox-html.el (org-html-table): For HTML5,
>   omit :html-table-attributes but not :id or :attr_html.

Thank you for your patch. Could you rebase it against "maint"? I cannot
apply it at the moment.

> +	       (unless (org-html-html5-p info)
> +		 (plist-get info :html-table-attributes))

One nitpick. It is more explicit to use:

  (and (not (org-html-html5-p info))
       (plist-get info :html-table-attributes))

since you are using the returned value.


Regards,

-- 
Nicolas Goaziou