emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Alain Schneble (Realize IT GmbH)" <alain.schneble@realize.ch>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Bug: clockreport in org-agenda-list - table misaligned if org-descriptive-links is nil
Date: Sat, 11 Apr 2015 14:11:53 +0200	[thread overview]
Message-ID: <876192sw3a.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <728674d5657a40168a56bc4927650df8@rintintin.hq.realize.ch.lan.rit> (Alain Schneble's message of "Mon, 30 Mar 2015 20:11:48 +0000")

Hello,

"Alain Schneble (Realize IT GmbH)" <alain.schneble@realize.ch> writes:

> Steps to reproduce:
> - if org-descriptive-links is non-nil, invoke M-x org-toggle-link-display
> - org-descriptive-links is now expected to be nil
> - M-x org-agenda-list
> - M-x org-agenda-clockreport-mode (or short: v R)
>
> Observation (given that there is at least some data being shown in the clockreport):
> 1) clockreport table is misaligned
> 2) clockreport table contains descriptive links even though org-descriptive-links is nil
>
> Cause:
> a) *org-agenda-list* /calls/ *org-agenda-prepare* which in turn /calls/ *org-agenda-mode*
> b) *org-agenda-mode* /calls/ (add-to-invisibility-spec '(org-link))
>    In contrast, *org-mode* /calls/ (if org-descriptive-links (add-to-invisibility-spec '(org-link))), hence makes adding org-link to the invisibility spec dependent on org-descriptive-links.
> c) the clockreport in the agenda list is constructed in
> *org-clock-get-clocktable* using a with-temp-buffer in whose context
> (org-mode) is called. The clockreport table will therefore be aligned
> based on the invisibility spec of org-mode which is different if
> org-descriptive-links was set to nil at the time *org-agenda-list* was
> called.

Thanks for the report and the analysis.

> Suggestions:
> 1.1) Inherit org-link invisibility spec in *org-clock-get-clocktable* from the "outer" mode (i.e. org-agenda-mode):
>      ...
>      (let ((descriptive-links (org-in-invisibility-spec-p '(org-link))))
>        (with-temp-buffer
>          (org-mode)
>          (if descriptive-links
>              (add-to-invisibility-spec '(org-link))
>            (remove-from-invisibility-spec '(org-link)))
>      ...
>      )
> 1.2) ... or make the call to *add-to-invisibility-spec* in *org-agenda-mode* dependent on org-descriptive-links as already done by *org-mode*

The latter sounds good. Do you want to prepare a patch for that?

> Btw, is there a reason why org-descriptive-links is global and not
> made buffer-local using make-variable-buffer-local after its defcustom
> definition? I had expected it to be buffer-local. If it isn't buffer
> local, the displayed links in different org buffers can get
> inconsistent with the flag hold in the org-descriptive-links variable.

If it is buffer local, we need a way to toggle it globally in all Org
buffers, possibly by adding an optional argument to
`org-toggle-link-display'.

WDYT?


Regards,

-- 
Nicolas Goaziou

      reply	other threads:[~2015-04-11 12:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-30 20:11 Alain Schneble (Realize IT GmbH)
2015-04-11 12:11 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=876192sw3a.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=alain.schneble@realize.ch \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).