From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: [PATCH] Fix tangling in indirect buffers Date: Tue, 08 Sep 2015 23:55:22 -0400 Message-ID: <87613knt5h.fsf_-_@kyleam.com> References: <87vbbq2qah.fsf@kyleam.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZWTw-0004BB-EI for emacs-orgmode@gnu.org; Tue, 08 Sep 2015 23:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZWTr-0004Ko-KN for emacs-orgmode@gnu.org; Tue, 08 Sep 2015 23:55:36 -0400 Received: from mail-qg0-f45.google.com ([209.85.192.45]:34050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZWTr-0004K0-Fz for emacs-orgmode@gnu.org; Tue, 08 Sep 2015 23:55:31 -0400 Received: by qgez77 with SMTP id z77so101144516qge.1 for ; Tue, 08 Sep 2015 20:55:30 -0700 (PDT) In-Reply-To: (Rainer M. Krug's message of "Mon, 07 Sep 2015 10:46:31 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rainer M Krug Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Rainer M Krug writes: > Kyle Meyer writes: > >> Rainer M Krug writes: >> >>> Hi >>> >>> it seems that tangling from an indirect buffer does not work. Is this by >>> design or a bug? >> >> I don't think that's by design. >> >>> Would it be possible to make this possible? >> >> Does the below patch work for you? If so, I can test it more thoroughly >> and send a proper patch. > > Yes - works perfectly. I would really appreciate this. Please submit. Patch against maint attached. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-tangling-in-indirect-buffers.patch >From 57beac5636d8be61c0e778d8b3f6da9d6ad208a6 Mon Sep 17 00:00:00 2001 From: Kyle Meyer Date: Tue, 8 Sep 2015 23:48:44 -0400 Subject: [PATCH] Fix tangling in indirect buffers * lisp/ob-tangle.el (org-babel-tangle-single-block): Get file name from base buffer. (org-babel-tangle): Use file name from attribute list returned by org-babel-tangle-single-block. Reported-by: Rainer M Krug --- lisp/ob-tangle.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el index d20c2b3..cf48db3 100644 --- a/lisp/ob-tangle.el +++ b/lisp/ob-tangle.el @@ -242,7 +242,7 @@ (defun org-babel-tangle (&optional arg target-file lang) (base-name (cond ((string= "yes" tangle) (file-name-sans-extension - (buffer-file-name))) + (nth 1 spec))) ((string= "no" tangle) nil) ((> (length tangle) 0) tangle))) (file-name (when base-name @@ -427,7 +427,7 @@ (defun org-babel-tangle-single-block (start-line (save-restriction (widen) (+ 1 (line-number-at-pos (point))))) - (file (buffer-file-name)) + (file (buffer-file-name (buffer-base-buffer))) (src-lang (nth 0 info)) (params (nth 2 info)) (extra (nth 3 info)) -- 2.5.1 --=-=-= Content-Type: text/plain -- Kyle --=-=-=--