* Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]
@ 2016-02-02 13:27 Michael Strey
2016-02-02 16:58 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Michael Strey @ 2016-02-02 13:27 UTC (permalink / raw)
To: emacs-orgmode
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
http://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------
When starting an org-drill session, I expect the answer to the question
to be hidden. Since my last update, I see question and answer at the
same time.
I tracked the problem down to commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258.
In function org-drill-hide-subheadings-if the following call of org-map-entries is
used:
(org-map-entries
(lambda ()
(when (and (not (outline-invisible-p))
(> (org-current-level) drill-entry-level))
(when (or (/= (org-current-level) (1+ drill-entry-level))
(funcall test))
(hide-subtree))
(push (point) drill-sections)))
"" 'tree)
Emacs : GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6)
of 2015-09-10 on foutrelis
Package: Org-mode version 8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)
--
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]
2016-02-02 13:27 Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)] Michael Strey
@ 2016-02-02 16:58 ` Nicolas Goaziou
2016-02-02 21:18 ` Michael Strey
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2016-02-02 16:58 UTC (permalink / raw)
To: Michael Strey; +Cc: emacs-orgmode
Hello,
Michael Strey <mstrey@strey.biz> writes:
> When starting an org-drill session, I expect the answer to the question
> to be hidden. Since my last update, I see question and answer at the
> same time.
>
> I tracked the problem down to commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258.
>
> In function org-drill-hide-subheadings-if the following call of org-map-entries is
> used:
>
> (org-map-entries
> (lambda ()
> (when (and (not (outline-invisible-p))
> (> (org-current-level) drill-entry-level))
> (when (or (/= (org-current-level) (1+ drill-entry-level))
> (funcall test))
> (hide-subtree))
> (push (point) drill-sections)))
> "" 'tree)
Could you provide an ECM?
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]
2016-02-02 16:58 ` Nicolas Goaziou
@ 2016-02-02 21:18 ` Michael Strey
2016-02-02 21:59 ` Nicolas Goaziou
0 siblings, 1 reply; 5+ messages in thread
From: Michael Strey @ 2016-02-02 21:18 UTC (permalink / raw)
To: emacs-orgmode
On Di, 2016-02-02 at 17:58, Nicolas Goaziou wrote:
[...]
> Could you provide an ECM?
Well, yes, maybe, but I would like to avoid this effort.
After reverting the mentioned commit, org-drill is working like expected again
and the function call:
(org-make-tags-matcher "")
evaluates to:
("" lambda (todo tags-list level)
(and (member todo org-not-done-keywords) (and t t)))
In HEAD it evaluates to:
("" lambda (todo tags-list level)
(and (member todo org-not-done-keywords) nil))
Hope that helps. If not, I will go and make my homework with the ECM.
Best regards
--
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]
2016-02-02 21:18 ` Michael Strey
@ 2016-02-02 21:59 ` Nicolas Goaziou
2016-02-03 8:35 ` Michael Strey
0 siblings, 1 reply; 5+ messages in thread
From: Nicolas Goaziou @ 2016-02-02 21:59 UTC (permalink / raw)
To: Michael Strey; +Cc: emacs-orgmode
Hello,
Michael Strey <mstrey@strey.biz> writes:
> After reverting the mentioned commit, org-drill is working like expected again
> and the function call:
>
> (org-make-tags-matcher "")
>
> evaluates to:
>
> ("" lambda (todo tags-list level)
> (and (member todo org-not-done-keywords) (and t t)))
>
> In HEAD it evaluates to:
>
> ("" lambda (todo tags-list level)
> (and (member todo org-not-done-keywords) nil))
>
Hopefully fixed in master. Could you confirm it?
Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)]
2016-02-02 21:59 ` Nicolas Goaziou
@ 2016-02-03 8:35 ` Michael Strey
0 siblings, 0 replies; 5+ messages in thread
From: Michael Strey @ 2016-02-03 8:35 UTC (permalink / raw)
To: emacs-orgmode
On Di, 2016-02-02 at 22:59, Nicolas Goaziou wrote:
> Hello,
>
> Michael Strey <mstrey@strey.biz> writes:
>
>> After reverting the mentioned commit, org-drill is working like expected again
>> and the function call:
>>
>> (org-make-tags-matcher "")
>>
>> evaluates to:
>>
>> ("" lambda (todo tags-list level)
>> (and (member todo org-not-done-keywords) (and t t)))
>>
>> In HEAD it evaluates to:
>>
>> ("" lambda (todo tags-list level)
>> (and (member todo org-not-done-keywords) nil))
>>
> Hopefully fixed in master. Could you confirm it?
Yes, org-drill works again. Thank you!
Best regards
--
Michael Strey
http://www.strey.biz * https://twitter.com/michaelstrey
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-03 8:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-02 13:27 Bug: Commit 2520fd654a65fe607a8ca726d7fc8fb5be07d258 breaking org-drill [8.3.3 (release_8.3.3-725-gdd15fe @ /usr/share/emacs/site-lisp/org/)] Michael Strey
2016-02-02 16:58 ` Nicolas Goaziou
2016-02-02 21:18 ` Michael Strey
2016-02-02 21:59 ` Nicolas Goaziou
2016-02-03 8:35 ` Michael Strey
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).