From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: HTML export fails to set source IDs correctly [8.3.4
 (8.3.4-elpa @ /Users/aaron/.emacs.d/elpa/org-20160222/)]
Date: Thu, 25 Feb 2016 21:19:53 +0100
Message-ID: <8760xc1r12.fsf@nicolasgoaziou.fr>
References: <56CE5C4D.5090100@aaron-miller.me>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aZ2MC-0001m9-LT
	for emacs-orgmode@gnu.org; Thu, 25 Feb 2016 15:17:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aZ2M9-0004q9-T1
	for emacs-orgmode@gnu.org; Thu, 25 Feb 2016 15:17:52 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48168)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1aZ2M9-0004q3-MG
	for emacs-orgmode@gnu.org; Thu, 25 Feb 2016 15:17:49 -0500
In-Reply-To: <56CE5C4D.5090100@aaron-miller.me> (Aaron Miller's message of
	"Wed, 24 Feb 2016 20:43:41 -0500")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Aaron Miller <me@aaron-miller.me>
Cc: emacs-orgmode@gnu.org

Hello,

Aaron Miller <me@aaron-miller.me> writes:

> Expected: When exporting an Org document with named source blocks to 
> HTML, each <pre> generated to contain a source block has an ID attribute 
> matching the source block's name.
>
> Actual: Instead, ID attributes come out with values like "orgsrcblock1".
>
> Test case:
> --- >8 cut here ---
> #+TITLE: bug test case
>
> #+NAME: a-source-block
> #+BEGIN_SRC emacs-lisp :eval never
> ;; hi
> #+END_SRC
> --- 8< cut here ---
>
> Expected result (its salient subset):
> --- >8 cut here ---
> <pre class="src src-emacs-lisp" id="a-source-block">
> ;; hi
> </pre>
> --- 8< cut here ---
>
> Actual result (its likewise):
> --- >8 cut here ---
> <pre class="src src-emacs-lisp" id="orgsrcblock1">
> ;; hi
> </pre>
> --- 8< cut here ---
>
> Note the erroneous ID attribute value.

The attribute is intended.

> The issue here is that, in `org-html-src-block' and 
> `org-html-inline-src-block', the fallback behavior for ID attribute 
> value is implemented in terms of `and', rather than `or'. Since `and' 
> short-circuits only when it encounters a null argument, the desired 
> behavior is effectively inverted.

Actually this is the desired behaviour: when a label is specified, make
sure to replace it with our internal unique and safe label. Hence the
`and'.


Regards,

-- 
Nicolas Goaziou