From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Make `org-tags-view' stop setting globally `org--matcher-tags-todo-only' Date: Tue, 30 May 2017 19:00:31 +0200 Message-ID: <8760gi5lg0.fsf@nicolasgoaziou.fr> References: <87k29rzdyh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFkVY-0006Fr-88 for emacs-orgmode@gnu.org; Tue, 30 May 2017 13:00:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFkVX-0006KE-FN for emacs-orgmode@gnu.org; Tue, 30 May 2017 13:00:36 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:59815) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dFkVX-0006K0-8T for emacs-orgmode@gnu.org; Tue, 30 May 2017 13:00:35 -0400 In-Reply-To: <87k29rzdyh.fsf@gmail.com> (Samuel Loury's message of "Thu, 19 Jan 2017 08:49:42 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Samuel Loury Cc: org-mode list Hello, Samuel Loury writes: > I would like to propose a patch for `org-tags-view' to make it stop > setting globally `org--matcher-tags-todo-only' > > Setting `org--matcher-tags-todo-only' has side effects on other > commands. For instance, the following clock table changes its behavior > whether `org--matcher-tags-todo-only' is nil or '(4) > > #+BEGIN: clocktable :tags "-perso" :fileskip0 :stepskip0 :link t :maxlevel 5 :emphasize t :link t :block today-1 :scope agenda :inherit-props t > > I did not have time to investigate why the behavior of the clock table > is impacted by `org--matcher-tags-todo-only'. I quickly feel lost in > this code. > > From c5c763a9aca8cfd8a707b0d7e814bc37f5eeafa1 Mon Sep 17 00:00:00 2001 > From: Samuel Loury > Date: Thu, 19 Jan 2017 08:39:50 +0100 > Subject: [PATCH] Make `org-tags-view' stop setting globally > `org--matcher-tags-todo-only' Thank you. I eventually fixed it slightly differently. Regards, -- Nicolas Goaziou