From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-protocol: fixes open-source and extends rewriting of
 URLs
Date: Sun, 25 Jun 2017 09:17:16 +0200
Message-ID: <8760fk4jur.fsf@nicolasgoaziou.fr>
References: <68E12968-9AF5-440A-B22C-AC55B70BA910@schnuddelhuddel.de>
	<87k248b6p8.fsf@nicolasgoaziou.fr>
	<7C76EDC3-CC7E-4AFE-B45B-867752C1B33A@schnuddelhuddel.de>
	<87a8519rlg.fsf@nicolasgoaziou.fr>
	<B2EC7C86-08BA-48A8-8B47-4875F00379E7@schnuddelhuddel.de>
	<8760fp9mui.fsf@nicolasgoaziou.fr>
	<2FAD7DF2-2A0C-4703-A383-BA8D3346C691@schnuddelhuddel.de>
	<18D83D3C-C472-4614-988F-1F1DA5EB5CEC@schnuddelhuddel.de>
	<87efub7psj.fsf@nicolasgoaziou.fr>
	<8CE2CFE3-2911-4369-8E93-E80CD25FD7E4@schnuddelhuddel.de>
	<5442AC7A-D45E-46FE-A3A7-3AB25679B3FE@schnuddelhuddel.de>
	<4427263B-5534-4FFD-AFA0-211EDA489001@schnuddelhuddel.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dP1nP-0008TG-P7
	for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 03:17:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dP1nO-0004FA-PR
	for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 03:17:23 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:53627)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dP1nO-0004Eb-Iw
	for emacs-orgmode@gnu.org; Sun, 25 Jun 2017 03:17:22 -0400
In-Reply-To: <4427263B-5534-4FFD-AFA0-211EDA489001@schnuddelhuddel.de> (Mario
	Martelli's message of "Sun, 25 Jun 2017 08:49:34 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Mario Martelli <tlmtr@schnuddelhuddel.de>
Cc: emacs-orgmode@gnu.org

Hello,

Mario Martelli <tlmtr@schnuddelhuddel.de> writes:
>
> Doing the tests for the documentation I encountered some issues with org-=
protocol.
>
> [0001-url-is-sanitized-before-processing]
> I=E2=80=99ve got trouble to get sub-protocol =E2=80=9Copen-source=E2=80=
=9D working in some cases. By sanitising the URL it works for me in all cas=
es.
>

[...]

> This changes the test of the URI which was tested against the resulting f=
ilename. It=E2=80=99s now tested against the base-url.
>
> I=E2=80=99m still unsure with this because the code is there for more tha=
n seven years. Maybe I=E2=80=99m not seeing something obvious here. But all=
 tests I made so far are succeeding with this change.
>

[...]

If all tests in "test-org-protocol.el" pass with your changes, I think
it is fine to apply them. Another round of tests for the cases you solve
would be nice, too.

Regards,

--=20
Nicolas Goaziou