From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: ox-html: Opt out of htmlize.el Date: Sun, 12 Nov 2017 23:30:34 +0100 Message-ID: <8760af165x.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eE0ly-0000Aa-GA for emacs-orgmode@gnu.org; Sun, 12 Nov 2017 17:30:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eE0lx-0000ZJ-Pl for emacs-orgmode@gnu.org; Sun, 12 Nov 2017 17:30:38 -0500 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:43939) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eE0lx-0000X8-Jn for emacs-orgmode@gnu.org; Sun, 12 Nov 2017 17:30:37 -0500 In-Reply-To: (Chunyang Xu's message of "Fri, 10 Nov 2017 00:28:15 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Chunyang Xu Cc: emacs-orgmode@gnu.org Hello, Chunyang Xu writes: > I think htmlize.el should be optional for ox-html. Although htmlize.el > is cool, there are still reasons to don't use it, e.g., > > - Colors looks nice in Emacs looks bad in the web browser > - No color at all in batch mode > - I want to use third party solutions such pygmentize and highlight.js > > When user sets org-html-htmlize-output-type to nil, don't use > htmlize.el. Since the code was already present in "ox-html", but not at the right branch in the `cond', this qualifies as a bugfix. I applied it to maint branch. Thank you. Regards, -- Nicolas Goaziou