From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns Date: Sat, 14 Apr 2018 18:31:44 +0200 Message-ID: <87604toikv.fsf@nicolasgoaziou.fr> References: <87zi272rlu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7O5g-0007tV-Cb for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 12:31:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7O5c-0003lm-FF for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 12:31:52 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56519) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f7O5c-0003lJ-8S for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 12:31:48 -0400 In-Reply-To: <87zi272rlu.fsf@gmail.com> (stardiviner's message of "Fri, 13 Apr 2018 20:55:25 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: org-mode-email Hello, stardiviner writes: > After about 5 times test, And about 4 times review. I decide to PR. Thank you. I applied the patches with some substantial changes to commit messages (often incomplete), removed "subr-x.el" calls (`thread-last' is just confusing) and fixed compilation warnings. Please double-check as I might have fumbled in the process. I didn't change "ob-clojure-literate.el" but there are dangling parens and whitespace issues to fix. Also, I don't see the need for `dash' library, but since it's a contrib/ package, I won't insist of it. Regards, -- Nicolas Goaziou