From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: org-habit: allow overriding org-scheduled-past-days and always including time of day Date: Sat, 02 Feb 2019 22:45:24 +0100 Message-ID: <875zu1dfuz.fsf@nicolasgoaziou.fr> References: <1541377860.1107531.1565461832.5F447B5E@webmail.messagingengine.com> <87k1ladke0.fsf@nicolasgoaziou.fr> <1549133427.1633527.1649374424.31A6A12F@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:52606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gq36n-00029a-Qr for emacs-orgmode@gnu.org; Sat, 02 Feb 2019 16:45:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gq36k-00019E-Lg for emacs-orgmode@gnu.org; Sat, 02 Feb 2019 16:45:53 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:38415) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gq36i-00012M-EE for emacs-orgmode@gnu.org; Sat, 02 Feb 2019 16:45:48 -0500 In-Reply-To: <1549133427.1633527.1649374424.31A6A12F@webmail.messagingengine.com> (John Lee's message of "Sat, 02 Feb 2019 18:50:27 +0000") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: John Lee Cc: emacs-orgmode@gnu.org Hello, John Lee writes: > Hi, sorry Nicolas I totally missed your review comments! No problem. > Trying hard to make up a reason for utility of the current behaviour: > let's say your habits tend to be weekly and have an optimum time and > weekday, but if you miss them it's just "as soon as possible". But if > anybody actually does see their habits that way, that would seem > likely to vary by habit. So I'd be surprised if the current behaviour > was very useful. > > Shall I make it the default, then? I think so. > Thank you. Right now I have one other change I'd like to submit which > is also tiny, do I need to start the assignment process? If both changes do not add up to around 15 non-trivial locs, that's fine. >> > +(defcustom org-habit-scheduled-past-days nil >> > + "Non-nil means the value of this variable will be used instead >> > +of org-scheduled-past-days, for habits only. >> >> First line needs to be a full sentence. Also, > > To me it looks like a full sentence? What I meant is the first line should contain only full sentences. Yours spans over two lines. > Should it be something like this below (based on looking at other docstrings)? > > "Value to use instead of `org-scheduled-past-days', for habits only. > > If nil, `org-scheduled-past-days' is used." That's better, indeed. > I think "as a mean of" is not correct English (I'm a native speaker in > the UK). Of course, you're right. Sorry for the noise. > Presumably I should use the version from the highest current git tag "plus one", i.e. 9.3? > > :package-version '(Org . "9.3") That's correct. Regards, -- Nicolas Goaziou