emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Fraga, Eric" <e.fraga@ucl.ac.uk>
Cc: Emacs Org mode mailing list <emacs-orgmode@gnu.org>
Subject: Re: patch: adding split-window-right option for src block editing
Date: Mon, 15 Jul 2019 12:02:04 +0200	[thread overview]
Message-ID: <875zo3obtv.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87wogosyxw.fsf@ucl.ac.uk> (Eric Fraga's message of "Thu, 11 Jul 2019 09:27:56 +0000")

Hello,

"Fraga, Eric" <e.fraga@ucl.ac.uk> writes:

> most of my work now involves using quite large wide monitors and having
> the editing of src blocks open windows below is less convenient than
> splitting horizontally.  I have added the option to split
> horizontally.  See attached patch.

Thank you. Could you provide an entry in ORG-NEWS, too?
>
> However, ideally, I would like the option to specify a function as
> context matters: sometimes a vertical split is better, sometimes
> not.  But implementing this was beyond my emacs-fu.

Allowing one to use a function is easy. It entails one additional value
in the defcustom, and one case in `org-src-switch-to-buffer':

  ((pred functionp) (funcall org-src-window-setup))

probably near the end since some symbols also are function names (e.g.,
`other-frame').

Implementing an interesting function is harder, but not necessary for
Org for the time being.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2019-07-15 10:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  9:27 patch: adding split-window-right option for src block editing Fraga, Eric
2019-07-15 10:02 ` Nicolas Goaziou [this message]
2019-07-16  7:00   ` Fraga, Eric
2019-07-24 11:22   ` Fraga, Eric
2019-08-17 13:27     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zo3obtv.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=e.fraga@ucl.ac.uk \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).