emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: immanuel <immanuel.litzroth@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-edit-src keeps splitting the window [9.2.5 (release_9.2.5-504-g3c24be @ /home/immanuel/.emacs.d/straight/build/org/)]
Date: Mon, 02 Sep 2019 21:41:00 +0200	[thread overview]
Message-ID: <875zmaqyer.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87r252swre.fsf@gmail.com> (immanuel's message of "Fri, 30 Aug 2019 13:44:37 +0200")

Hello,

immanuel <immanuel.litzroth@gmail.com> writes:

> When org-edit-src-code is called with org-window-setup equal to
> 'split-window-below or 'split-window-right it will keep splitting the
> window if the mouse is clicked on the src block in the org buffer.
> This patch tries to address that

[...]

> +(defun org-src-select-window-for-buffer (buffer split-fun)

You should make it an internal function: `org-src--select-window-for-buffer'.

> +  "Tries to select an existing window for buffer or splits the
> window."

You need to expound the docstring a bit, e.g.:

  "Re-use an existing window or split the current window.
  If BUFFER is current in a window, use it.  Otherwise, split the current
  window, according to SPLIT-FUN, in order to display it.

Also, I think this should be notified in ORG-NEWS file.

Thank you!

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-09-02 19:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 11:44 Bug: org-edit-src keeps splitting the window [9.2.5 (release_9.2.5-504-g3c24be @ /home/immanuel/.emacs.d/straight/build/org/)] immanuel
2019-09-02 19:41 ` Nicolas Goaziou [this message]
2019-09-02 21:26   ` Immanuel Litzroth
2019-09-03 16:17     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zmaqyer.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=immanuel.litzroth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).