From mboxrd@z Thu Jan 1 00:00:00 1970 From: Terje Larsen Subject: =?UTF-8?B?QnVnOiBvYi1wbGFudHVtbDogdXNpbmcgQHN0YXJ0IHByZWZpeCBp?= =?UTF-8?B?biBidWZmZXIgcmV0dXJucyBuaWwgYm9keSBkdWUgdG8gbmlsIGFzc2lnbm1l?= =?UTF-8?B?bnRzIFtOL0EgKE4vQSBAIC9uaXgvc3RvcmUvMWhteDVoMWtuMjVwN3MzMWgz?= =?UTF-8?B?MWR6N2cza24xZGM2cXgtZW1hY3MtcGFja2FnZXMtZGVwcy9zaGFyZS9lbWFj?= =?UTF-8?B?cy9zaXRlLWxpc3Avb3JnLyld?= Date: Fri, 08 Nov 2019 00:06:24 +0100 Message-ID: <875zjv5lsf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:58142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSqrH-0000by-69 for emacs-orgmode@gnu.org; Thu, 07 Nov 2019 18:06:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSqrF-0007rA-TT for emacs-orgmode@gnu.org; Thu, 07 Nov 2019 18:06:30 -0500 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:35449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iSqrF-0007mc-IY for emacs-orgmode@gnu.org; Thu, 07 Nov 2019 18:06:29 -0500 Received: by mail-lf1-x130.google.com with SMTP id y6so2928488lfj.2 for ; Thu, 07 Nov 2019 15:06:28 -0800 (PST) Received: from beetle ([185.176.246.120]) by smtp.gmail.com with ESMTPSA id r19sm1534076lfm.61.2019.11.07.15.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 15:06:25 -0800 (PST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Remember to cover the basics, that is, what you expected to happen and what in fact did happen. You don't know how to make a good report? See https://orgmode.org/manual/Feedback.html#Feedback Your bug report will be posted to the Org mailing list. ------------------------------------------------------------------------ I noticed that I cannot run C-c C-c to convert plantuml source blocks since the commit (4e854974be9788f029f2d73f829c4d51d2b83faf), see changes at: https://code.orgmode.org/bzg/org-mode/commit/4e854974be9788f029f2d73f829c4d51d2b83faf#diff-9c9a333463276ff17be763269a5042f92a40817R73 If I have a simple source block as such as: #+BEGIN_SRC plantuml :file output.png @startuml actor Foo1 actor Foo2 Foo1 -> Foo2 : Test @enduml #+END_SRC When I try to run C-c C-c I receive the following error message: org-babel-execute-src-block: Wrong type argument: char-or-string-p, nil During my debugging I found out that assignments inside the function org-babel-plantuml-make-body returns nil and that causes the function to return nil which is not expected behavior. I remember this working before, so I went looking through the history and noticed the addition of this code. To me it looks like the logic is wrong. As the expression: (org-babel-variable-assignments:plantuml params) Could not possibly not return the body and without the body the content will be invalid. I have verified that reverting this commit fixes the issue and lets me generate PlantUML files. Emacs : GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.12) Package: Org mode version N/A (N/A @ /nix/store/1hmx5h1kn25p7s31h31dz7g3kn1dc6qx-emacs-packages-deps/share/emacs/site-lisp/org/)