From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6K12NCA6DmASOQAA0tVLHw (envelope-from ) for ; Mon, 25 Jan 2021 03:25:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 8AQmMCA6DmDHdQAAbx9fmQ (envelope-from ) for ; Mon, 25 Jan 2021 03:25:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 062209404DF for ; Mon, 25 Jan 2021 03:25:19 +0000 (UTC) Received: from localhost ([::1]:48508 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3sVC-0004R9-KL for larch@yhetil.org; Sun, 24 Jan 2021 22:25:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39344) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3sTt-0003d0-GP for emacs-orgmode@gnu.org; Sun, 24 Jan 2021 22:23:57 -0500 Received: from out0.migadu.com ([94.23.1.103]:20556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3sTq-0000e8-Sz for emacs-orgmode@gnu.org; Sun, 24 Jan 2021 22:23:57 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1611545028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OoTYvKcL7HpV1KhF7ECFUYdBT8m+Vt7OQp1Nax6Zozs=; b=hQZQMlVrXgfId7gqx8iIlklAzYk0Idwdxgu2IYTAJXfJuanPnOyfwYA9IS1VvIc6ewQj4G yNDZyzAtYefm/oQ88GsYa2IavZIrq5n/pcFZhciBJiCXVaQnmZVuzhJY95aQz4QrAd2wUr IeOPD+iXwMFj/lt+29NGsuG0aLm/kaote5v2bQsJksdrZUzsVGRLtFtflNja3erCiu6Pjg PwlBUElV+OxlPn4X+WisZqGcizbSbIr/i11Yp4j/Kcc/DGFYcFCzNpp2roOJbeSOFfNI+L QQ/dMU6GxH3jMN8HR2XKxOkINUHDBuEXTjhr7jyQIDMcwPkXxdazo7o2gO/FLw== From: Kyle Meyer To: Daniel =?utf-8?Q?Gr=C3=B6ber?= Subject: Re: [PATCH] org-macs: Allow specifying relative time in hours In-Reply-To: <20210105004855.4315-1-dxld@darkboxed.org> References: <20210105004855.4315-1-dxld@darkboxed.org> X-Woof-Patch: applied Date: Sun, 24 Jan 2021 22:23:46 -0500 Message-ID: <875z3lvgvx.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Auth-User: kyle@kyleam.com Received-SPF: pass client-ip=94.23.1.103; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.55 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=hQZQMlVr; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 062209404DF X-Spam-Score: -2.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: Vke/nCJqO6j4 Daniel Gr=C3=B6ber writes: > This adds support for date expressions such as +12h to > org-matcher-time. The regexp this function uses to parse such relative > expressions already includes the "h" character but doesn't actually > handle that case. > > AFAICT org-mode commit ec921a2a68 ("Support hourly repeat cookies") > neglected to add support here. Thanks for the analysis and patch. This looks good to me. Applied (aeb9f036f), adding a changelog message to the patch and a TINYCHANGE cookie (see ). I've also followed up your commit with a commit that adds a few tests for org-matcher-time, including for h.