emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: "Daniel Gröber" <dxld@darkboxed.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-macs: Allow specifying relative time in hours
Date: Sun, 24 Jan 2021 22:23:46 -0500	[thread overview]
Message-ID: <875z3lvgvx.fsf@kyleam.com> (raw)
In-Reply-To: <20210105004855.4315-1-dxld@darkboxed.org>

Daniel Gröber writes:

> This adds support for date expressions such as +12h to
> org-matcher-time. The regexp this function uses to parse such relative
> expressions already includes the "h" character but doesn't actually
> handle that case.
>
> AFAICT org-mode commit ec921a2a68 ("Support hourly repeat cookies")
> neglected to add support here.

Thanks for the analysis and patch.  This looks good to me.  Applied
(aeb9f036f), adding a changelog message to the patch and a TINYCHANGE
cookie (see <https://orgmode.org/worg/org-contribute.html>).

I've also followed up your commit with a commit that adds a few tests
for org-matcher-time, including for h.


      reply	other threads:[~2021-01-25  3:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  0:48 Daniel Gröber
2021-01-25  3:23 ` Kyle Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z3lvgvx.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=dxld@darkboxed.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: [PATCH] org-macs: Allow specifying relative time in hours' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).