From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6FchDeT+JmDNFAAA0tVLHw (envelope-from ) for ; Fri, 12 Feb 2021 22:19:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id eFHOCOT+JmAPFAAAbx9fmQ (envelope-from ) for ; Fri, 12 Feb 2021 22:19:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7A5A014941 for ; Fri, 12 Feb 2021 23:19:15 +0100 (CET) Received: from localhost ([::1]:52440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAgmQ-0006Vh-K8 for larch@yhetil.org; Fri, 12 Feb 2021 17:19:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53652) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAgkW-0006UL-Iv for emacs-orgmode@gnu.org; Fri, 12 Feb 2021 17:17:16 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:35876) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAgkT-0004Ft-CJ for emacs-orgmode@gnu.org; Fri, 12 Feb 2021 17:17:16 -0500 Received: by mail-pf1-x436.google.com with SMTP id z15so376068pfc.3 for ; Fri, 12 Feb 2021 14:17:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=SaggHrPKN58JhYiH3dj6lqM3MZ5jhht2afBipTdaCfE=; b=pBV5zf3PfwR/KyXIM8uA4B8RJ5S8mn+PQ+itYRqG+sCHGNFS2dDeNXjyM3Vi+alXwk fYOjGL7k/D8Ek8+g2QTVfAFbMrLyVjrVJNMQmX2i712vHLn8Fwye4TJ45HGiCgvjCVQN RcQZd9vqZfEx31rkG11+QrCX92cmJsnW2ZBgd2EN5edV4DGG1l6EUyFijOvXgF4RRdkq gY/Dr2T21UwhtL5RjVl8z4D4+VdbOU8I6uJT8oxHlzxr4XP7P4tjMEdCnuh4WjrvvkUk lk/lybYEBfR2BoRull7MghIDeXkiVR5pOwZkAlbHvby7EbHY4ps6bmM+MeIHiZP4Vios Ux1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=SaggHrPKN58JhYiH3dj6lqM3MZ5jhht2afBipTdaCfE=; b=AOIxJprrxHHu2HML/wdArsEnXdHLO8Df2BY+q+wDMWIMtts1UI/qaOOaYBfuA7L/af ESsQ7TBiQrp2zx9n0gzhk/RbCwAJxry3wQQSW6yK/Y8HuGtOA9DUKrcevfHpb/xVfELp fl7g8IXmWsU6nWiE8nRp2ocRTTDJ12duvoSkxMsCJTWmIbo1+QUCzqh+ewuKDjFqAZ2q 0PqTiGEXz0cBeApul+EAoRaENIywpySL1C/GnhhVyXeKo7AssH48BGJu/3Pugm3vFbbg uEnezEYl+Yt8ea1Hmyd6xLpLtrpYD3mxUyL7HQ9XC+0WuAOSUgH2V+iy2sMfGFEYBrUA 7HEQ== X-Gm-Message-State: AOAM5300nbYJvZmHS3k5eFtoTaq5eMsXeWk4wJwF9ovY7aSGXqVXAIdb BLHeTXsnPtz5rPsxKGVwzsOLr9k/qII= X-Google-Smtp-Source: ABdhPJyxprZYHa1QBFGVqJ49SrB+zJqDo2fsY0WOKYIXFLx/SjcyI7YCOoBQKqWcD76vCUcQqNxOEQ== X-Received: by 2002:a62:384c:0:b029:1e3:8bca:5701 with SMTP id f73-20020a62384c0000b02901e38bca5701mr4883583pfa.7.1613168231171; Fri, 12 Feb 2021 14:17:11 -0800 (PST) Received: from tim-desktop (106-69-127-195.dyn.iinet.net.au. [106.69.127.195]) by smtp.gmail.com with ESMTPSA id y9sm10323847pfr.192.2021.02.12.14.17.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 14:17:10 -0800 (PST) References: <87turbj2nu.fsf@gmail.com> <878s7t95fu.fsf@kyleam.com> <87wnvd2ph3.fsf@wi.uni-muenster.de> User-agent: mu4e 1.5.8; emacs 27.1.91 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: [PATCH] tweaks to ox-html style Date: Sat, 13 Feb 2021 08:46:52 +1100 In-reply-to: <87wnvd2ph3.fsf@wi.uni-muenster.de> Message-ID: <875z2xylr0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=theophilusx@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.06 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=pBV5zf3P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 7A5A014941 X-Spam-Score: -3.06 X-Migadu-Scanner: scn1.migadu.com X-TUID: dSalLDBh7uof Jens Lechtenboerger writes: > On 2021-02-12, Kyle Meyer wrote: > >> TEC writes: >> >>> Hi All, >>> >>> This is just some tweaks to the styling in ox-html that I think may >>> appeal (and prevent ridiculously long lines on non-small displays, which >>> are an issue for legibility). >>> >>> I also took the opportunity to remove the (obsolete) CDATA strings and >>> make the CSS more consistently formatted. If you don't want this to >>> get its own commit, please just squash it. >>> >>> Style changes: >>> - Restrict max content width, and centre >>> - tweak styling of source code blocks >> >> I'm sure there are plenty of opinionated ox-html users on the list. Is >> anyone willing to provide feedback on this series? Please don't assume >> you need commit access to provide reviews. > > Hi there, > > I do not know why the CDATA lines exist. I don=E2=80=99t see a reason to > keep them (patch 0001), but that might be a lack of understanding on > my part. > > Patch 0003 is about whitespace fixes. > > Patches 0002, 0004, 0005 change defconst styling. I don=E2=80=99t have a > strong opinion here. However, if they are changed now, what about > turning them into defcustoms? Then each of us would be entitled to > their own opinion ;) > > The docstring for org-html-head-include-default-style says that > org-html-style-default (a defconst proposed to be changed here) > should not be changed. Why not? > I think I pretty much agree here. IMO I think all the CSS styling in an export should be defined with defcustom. CSS has come a long way since the original HTML exporter was written and I think it is best to put this power in the hands of the author. I realise some of this CSS styling can be complex if we want good looking HTML exports and making it available to be changed by the user could result in an increase in issues relating to inconsistent or ugly output, but I think provided the defaults are good, this risk is warranted. My only question is whether we should continue to modify the current html exporter or whether it would be better to rename the existing exporter as xhtml exporter and do a new clean html exporter that is just html5 and css3 and which does not attempt to be xhtml compliant? Others have mentioned on the list that they believe it is important to keep xhtml compatibility. This would satisfy that requirement and at the same time, enable a new html exporter that can take full advantage of changes introduced with html5 while keeping the exporter smaller and cleaner (and easier to maintain). BTW I think it would be nice if the html export was able to produce/use a separate CSS file rather than in-line styles. This would make it easier to drop exported HTML files into existing sites with custom styles or update the look of exported files without needing to re-export or manually edit. The complication is with exporting of HTML snippets, where you probably want in-line styles. -- Tim Cross