emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: pillule <pillule@riseup.net>
To: Kyle Meyer <kyle@kyleam.com>
Cc: pillule <pillule@riseup.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-src.el Do not ask to revert unmodified buffers
Date: Fri, 26 Mar 2021 03:10:00 +0000	[thread overview]
Message-ID: <875z1eehla.fsf@host.localdomain> (raw)
In-Reply-To: <87wnu0tffu.fsf@kyleam.com>


You are right I clearly missed 
org-src-ask-before-returning-to-edit-buffer
Don't know how . . .

Sorry for the noise.


Kyle Meyer <kyle@kyleam.com> writes:

> Thanks for the patch.
>
> pillule writes:
>
>> Hi, it is asked to the user if we want to revert changes when 
>> re-entering in a org-source buffer.
>> Even if the buffer have no modifications.
>
> Hmm, that description seems to be focusing on the prompt's 
> parenthetical
> note.  When org-src-ask-before-returning-to-edit-buffer is 
> non-nil and
> there's an existing source buffer, the caller is asked whether 
> to return
> to it or regenerate/overwrite it.  The message warns that the 
> second
> option (i.e. answering "no, don't return to existing buffer") 
> will
> discard changes.
>
> It looks like this patch assumes that, when the buffer is 
> unmodified,
> the answer to the above question necessarily becomes "yes, 
> return to the
> existing buffer", but it's not clear to me why that should be. 
> With an
> unmodified buffer, I suppose there's less of a difference 
> between the
> two answers, but at least with the default org-src-window-setup 
> value,
> there's still a user-visible difference in terms of window 
> organization.


-- 




  reply	other threads:[~2021-03-26  3:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 22:57 pillule
2021-03-08 23:03 ` pillule
2021-03-08 23:06   ` pillule
2021-03-21 20:33 ` Kyle Meyer
2021-03-26  3:10   ` pillule [this message]
2021-05-01 10:55     ` Timothy
2021-05-01 10:58       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z1eehla.fsf@host.localdomain \
    --to=pillule@riseup.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --subject='Re: [PATCH] org-src.el Do not ask to revert unmodified buffers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).