From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2I5GIAe9jWCoDwEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:41:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2NzUGwe9jWDOaAAAbx9fmQ (envelope-from ) for ; Sat, 01 May 2021 20:41:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DBA64194CE for ; Sat, 1 May 2021 22:41:42 +0200 (CEST) Received: from localhost ([::1]:48158 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcwQo-00020Y-14 for larch@yhetil.org; Sat, 01 May 2021 16:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcwQO-00020R-NB for emacs-orgmode@gnu.org; Sat, 01 May 2021 16:41:16 -0400 Received: from mail-qk1-x730.google.com ([2607:f8b0:4864:20::730]:44977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lcwQL-0006CT-Kw; Sat, 01 May 2021 16:41:16 -0400 Received: by mail-qk1-x730.google.com with SMTP id a2so1609459qkh.11; Sat, 01 May 2021 13:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:references:user-agent:from:to:cc:subject:in-reply-to :message-id:date:mime-version; bh=CkwC0wEWJZ+Uwy6JUzgr7U0+/FlkTpxQr0Tmz/DJhrM=; b=t9ann9Yfsx99U/9SM+fk5SYiidA8JYO9kb0kv0xzcERR46GZ4Bbqp+/CkbcL/o+Bl2 kJ9vvMgiwJ2zRN4b0W+Z2qwBoKoxtborMqvyPQzNT23yzEKF6N4Btv8haFc/L8cKcj1h C/FL5UmhLXzxP3CVWI61AssJygNP9ghubLfyM0JQCbacq+bnuDj7x1R/pvH3H1ij3+qx fR4VaS71TgiiKT0z+ZDGIunVBRWtcDzzWMk4O/AZQFJeobXDRqfN5WsdYRgLlm6UyT6X m/4pRg24kyxi8y1TuSZsMFBZb5x5NT0jB4F3bHfbInfMGGzbl/UpNLR6dn4An0k3gHES e0uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:references:user-agent:from:to:cc:subject :in-reply-to:message-id:date:mime-version; bh=CkwC0wEWJZ+Uwy6JUzgr7U0+/FlkTpxQr0Tmz/DJhrM=; b=pr0aHYAQAbmtbSGspQvj3ONlUG5l5PVGvwFLCbQymaVWt8cFKLr7PjSdL8PYBF8G1r P21w6ewkzvRLfTmfQEw1PGkfqBiNe4oQZn7r3AZaSN9um5e4zAXE3VUtVitPDLmx0h9K I4IYppHk45mbd4mnq0jX1ipR6wZXsC0nFUHKfjBitpcc+pfzjQT6wQhqIaTu8kXcENZV RjtfuVe10qjmUBbDsXD0gdzFggE8PRMJ3zsNeMrV3xL/ToCCdzcc9GZXN5e9LELI0XXe cPoHOu3ejiWtkneenYRhAFwRgWyX4kqRe+7ygAZfFgR180rlLpLZdtz2RKLUYqjgUfvN 8+Yw== X-Gm-Message-State: AOAM530fPXB8nl0Ev79cFzhhv/atYAdO7okpuGNUmLr6jyrHhIzeEM1O +YzMnPljSyX0ByxIRHMZRpHZqz+PjlptXQ== X-Google-Smtp-Source: ABdhPJw502S7oTBBXoazUBdMs4ZztKgFaUsoAATuGbxlD3GiNURrqkgP8KpaWoyt7fns47uclSTKjA== X-Received: by 2002:a05:620a:3c3:: with SMTP id r3mr11557293qkm.35.1619901671991; Sat, 01 May 2021 13:41:11 -0700 (PDT) Received: from gusbrs-laptop ([156.146.42.130]) by smtp.gmail.com with ESMTPSA id l22sm1110498qtn.21.2021.05.01.13.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 13:41:11 -0700 (PDT) References: <87o8jnzjao.fsf@gmail.com> <87r1iq9zht.fsf@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Gustavo Barros To: Bastien Subject: Re: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)] In-reply-to: <87r1iq9zht.fsf@gnu.org> Message-ID: <875z02i3vf.fsf@gmail.com> Date: Sat, 01 May 2021 17:41:08 -0300 MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::730; envelope-from=gusbrs.2016@gmail.com; helo=mail-qk1-x730.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619901703; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=CkwC0wEWJZ+Uwy6JUzgr7U0+/FlkTpxQr0Tmz/DJhrM=; b=UU6Ihy+Tr77E2YP9gxUBmyAN3SDVQe17T+PoG4l5rE+NN7sYrdK8mls6UCGk5gb+zbsePj 2cmfuPtuNjrGxs49vdJCSUlFB2Y68oeAIe5SlJxSz2pniMHgyGpBIKzhVtye0W4JrgNUqF 8yiwoiB9ZIv5bUVWD4np1MDhOHOWkAnrgfXK/euhGCjdZuG+PJnL0ebdIrPtuGr05zmTON y7WvT3t6sJMdrXDKHy87WsJa3XnKbScs+6bILRQYaISzZ9/4durwgJJj5x4/4Y1yrWP8eo 5tw2ZCHya3M/pI7B3URS9tag/Q5bnFFIDov/sz3HCNv9Zr7B5P0iMJ7OG0LJIQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619901703; a=rsa-sha256; cv=none; b=Orh/whnrKszs4rsT9MN28IF98UiQJKs7G3POns4zm8PnyuovZxvb3tU8rxMGuACqM8fRfJ up0dfrqv+ITeelvPMx9KX5ejFSczALQwV5qI59Zy6+b0xXXvKuapruJzmTVclcAfeZelMs si46HICig1JE6WlTfgDWlrjygDm2mryRwLKOC9Us3M2mSeVt+Gefdr9+jnMbSDm23mJbp8 Q6/54oUxhgyWBp4PUvdgYosYesdXRvKAG2ZgkMGVX1lwYbFkgbu3fDkZDolmMGr30tX605 KrmEOyY6zn2/eU98QnRiwOP1aEMOqM+rt7DDX3SPZl7iEdk+x26cZbAjkq1Kbg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=t9ann9Yf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.36 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20161025 header.b=t9ann9Yf; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DBA64194CE X-Spam-Score: -1.36 X-Migadu-Scanner: scn0.migadu.com X-TUID: OcMeQM0osdgX Hi Bastien, On Sat, 01 May 2021 at 13:42, Bastien wrote: > Hi Gustavo, > > Gustavo Barros writes: > >> when using `org-hide-emphasis-markers', making links visible with >> `org-toggle-link-display' also unhides the emphasis markers. I >> believe >> this to be unexpected behavior (it certainly is to me), but I might >> be >> wrong here, given that the emphasis markers are explicitly set to a >> `org-link' invisible property (which see). > > thanks for reporting this, I've committed 842ab092a in maint which > should fix it. > Thank you for looking into this, and for the fix. > I hope the change does not break anyone's code: perhaps some people > use custom code to hide/show emphasis markers based on the org-link > invisible property specs. > > In any case, I don't think `org-toggle-link-display' should display > emphasis markers. I'm not sure either. Perhaps that was the reason why `org-link' was used as the invisibility property there in the first place. If you think that is a concern, perhaps adding something as `org-emph' to the invisibility specs and using it there instead of leaving the markers in the default group might be a good idea. This way it would be possible to toggle the markers selectively, as it is done with the links. I'm not sure this is granted, but one reasonable hypothesis why `org-link' was used there in the first place is that some degree of selective toggling of the markers was somehow demanded. Best, Gustavo.