emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Gustavo Barros <gusbrs.2016@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)]
Date: Sat, 01 May 2021 17:41:08 -0300	[thread overview]
Message-ID: <875z02i3vf.fsf@gmail.com> (raw)
In-Reply-To: <87r1iq9zht.fsf@gnu.org>

Hi Bastien,

On Sat, 01 May 2021 at 13:42, Bastien <bzg@gnu.org> wrote:

> Hi Gustavo,
>
> Gustavo Barros <gusbrs.2016@gmail.com> writes:
>
>> when using `org-hide-emphasis-markers', making links visible with 
>> `org-toggle-link-display' also unhides the emphasis markers.  I 
>> believe 
>> this to be unexpected behavior (it certainly is to me), but I might 
>> be 
>> wrong here, given that the emphasis markers are explicitly set to a 
>> `org-link' invisible property (which see).
>
> thanks for reporting this, I've committed 842ab092a in maint which
> should fix it.
>

Thank you for looking into this, and for the fix.

> I hope the change does not break anyone's code: perhaps some people
> use custom code to hide/show emphasis markers based on the org-link
> invisible property specs.  
>
> In any case, I don't think `org-toggle-link-display' should display
> emphasis markers.

I'm not sure either.  Perhaps that was the reason why `org-link' was 
used as the invisibility property there in the first place.  If you 
think that is a concern, perhaps adding something as `org-emph' to the 
invisibility specs and using it there instead of leaving the markers in 
the default group might be a good idea.  This way it would be possible 
to toggle the markers selectively, as it is done with the links.  I'm 
not sure this is granted, but one reasonable hypothesis why `org-link' 
was used there in the first place is that some degree of selective 
toggling of the markers was somehow demanded.

Best,
Gustavo.



  reply	other threads:[~2021-05-01 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24  0:32 Gustavo Barros
2021-05-01 16:42 ` Bastien
2021-05-01 20:41   ` Gustavo Barros [this message]
2021-05-02  6:30     ` Bastien
2021-05-02 16:06       ` Gustavo Barros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z02i3vf.fsf@gmail.com \
    --to=gusbrs.2016@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: Bug: org-toggle-link-display and org-hide-emphasis-markers [9.4 (9.4-44-g5272d9-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20201123/)]' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).