From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id QK4yDG/lq2EKGwAAgWs5BA (envelope-from ) for ; Sat, 04 Dec 2021 23:02:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sNDgB2/lq2GaAwAA1q6Kng (envelope-from ) for ; Sat, 04 Dec 2021 22:02:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 89D882838B for ; Sat, 4 Dec 2021 23:02:21 +0100 (CET) Received: from localhost ([::1]:35400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtd6q-0004cF-ML for larch@yhetil.org; Sat, 04 Dec 2021 17:02:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtd6M-0004c6-Cj for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 17:01:50 -0500 Received: from [2607:f8b0:4864:20::1032] (port=52757 helo=mail-pj1-x1032.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtd6K-0003Bo-LN for emacs-orgmode@gnu.org; Sat, 04 Dec 2021 17:01:50 -0500 Received: by mail-pj1-x1032.google.com with SMTP id h24so4958364pjq.2 for ; Sat, 04 Dec 2021 14:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=qFRxRl3Imf/4z4PNiDtwEYfQ9L1l4jzKul1iK6FtwS8=; b=WRWrOmDCRd0hSSwvxzENg1wUcwON4oEzLrRDf6htrdTcqZ0sykMv4gn9nIipAIqJQe ASeU9L/Yu9/3KazcP+k3uUyg3TsAIVaQC8hv3DApPxkr/DqsC2zPbNZQWdOuJeLcAid5 hmupmiS2pEgZ/1vieZzmuCQFE6xbCWcfp9DDV2X5dwcikt7srgGDzrks9uXxuVtSVD86 u2mViaDaNJQjWsca2u4FoE+526wyq/8hNCFpMbiZ0RfSGhu2GFdefDm1B3GjU2uNbzFz 7cZu5O30IHrxzlZjEFWd+htxhzF6NrbHytiZ23Dm7wum7nbPa2ELFU8nC1f3LvXlMyOh kPAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=qFRxRl3Imf/4z4PNiDtwEYfQ9L1l4jzKul1iK6FtwS8=; b=js57z+rCaBPGeKM9o8pn8EXfOKPbD5ea+kGCXcgaymb3jtMj0Q2OteBbA0G6auwRnH nu8jhGVhpLUUooEJQITRzB2EZB+Inc5S3P8npdz8CNomWtquY5cXGcEAs+LXcNjCwA+h 93W8HdnnnIdKA4MBXdb+SE+v3rQnR+yrpqQp7JY5wVGBA/dBHSHq8+Ee8+442wr2bz33 OLNirxfs0kGNPe8AP6GZ7jR/oFCMsrLXaRPIUl+/yQeDMZ4jVHBCZYhG6YcZqWtXESuo bR8j1Qc/TpN4SvyZVexk94kNW7L2KLUoYBx2hNuyd0pIOSLyZgkGsS902koF9VoJT8O5 7YNQ== X-Gm-Message-State: AOAM531mc6FSCHsb/nSZvNr2j1BPZJJ0NpKOiEBO+vxDn/ebor9qowpk L+5Yp4m/Bw5iDpgVgmStY9JxZVvjq1c= X-Google-Smtp-Source: ABdhPJyhKARVNEMDCIVBN6SGTE+rCjZ0QCuJo8v8EZWJmde48N1O0/CWkB1aV4ZDqyCxjrrlF7+PGw== X-Received: by 2002:a17:902:e405:b0:141:b2fa:b00 with SMTP id m5-20020a170902e40500b00141b2fa0b00mr32532836ple.22.1638655306966; Sat, 04 Dec 2021 14:01:46 -0800 (PST) Received: from dingbat (2001-44b8-31f2-bb00-ae68-ae3c-97fa-f661.static.ipv6.internode.on.net. [2001:44b8:31f2:bb00:ae68:ae3c:97fa:f661]) by smtp.gmail.com with ESMTPSA id y28sm7313927pfa.208.2021.12.04.14.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Dec 2021 14:01:46 -0800 (PST) References: <5a675071-292a-1f10-9791-5085a6d8bef8@posteo.eu> <87r1atgsyt.fsf@gmail.com> <03abcf31-001b-5ca7-244f-fef94f63b569@posteo.eu> User-agent: mu4e 1.7.5; emacs 28.0.90 From: Tim Cross To: sebastien.miquel@posteo.eu Subject: Re: [PATCH] org-src.el: add option `org-src-native-defun-movements' Date: Sun, 05 Dec 2021 08:51:41 +1100 In-reply-to: <03abcf31-001b-5ca7-244f-fef94f63b569@posteo.eu> Message-ID: <875ys4uj08.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1032 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=theophilusx@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638655341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=qFRxRl3Imf/4z4PNiDtwEYfQ9L1l4jzKul1iK6FtwS8=; b=aSZOPOXAJ7dh/pUJSBJSGrgEMMnuN69t3WjFK1v2ugml4QYVN7fpeOUCL895CEzuMVgF+R N3y7sM/ueSevJNo1Pka4bHKo/zlhgR14BTDskDoOQrf2pXzo9D2OkUVLYecvHc7LWFgozp sKiDusfHU7KIOY5oYsi1sKi/Aii0I4XjojHPCOK6A/imUf6AC7NzwAhrhp+UgjFzX6G0yF fIXBnVElPUU4w1ASs6eVQ5FogOcDbfPoTHiB5/dEuEjUSfyAmZvI7T4xNbiOCgd+FYD9m2 jjHdnoqSFRkDkIGhkjyAgLcEd7Oxkt260AXMyy/RTfEI60+qfZxFDw0JytZF/g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638655341; a=rsa-sha256; cv=none; b=DTM29AVSo+utU5gtVdQKHkyAZxtX5R750LuZz6RGkBvea9OUif9ZpTm2NeROFmmeAkWzD7 dE07YK2/yy+fL6aSWg+xXmxDZ4MpaB7EXzLRiCrmZ5ULnExdcIceJWuVskCFVbEbtiiYSY sbARmbebjqEoGur30enWnanuEfKizxa16YBvQFIl+i9QpkwcKXWRIdUOKMeM9LtisW3bwj PQ1+n0dZyE4ls3Dd1H/AmAU/HIuvMEa52EnLUTCYz5xYryhb3ukgrFfsRCme2ZvdsRhslA IVsfAFpd8rIhY29SIJbDA79Qb5WACBJfQ3HF5VXBOkEwmkGfoqvmVKz1A3eslQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WRWrOmDC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WRWrOmDC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 89D882838B X-Spam-Score: -4.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: l4n1j19TIqXm S=C3=A9bastien Miquel writes: > Hi, > > Thank you for having a look. > > Tim Cross writes: >> This also seems like an edge case and I'm not convinced yet another >> option is justified. Why have eilisp in org blocks rather than an >> emacs-lisp block? > > By org src blocks I meant an org emacs-lisp src block. The point of > the patch is to be able to eval-defun some lisp code in an emacs-lisp > src block from the org-buffer. > OK, that makes it clearer. However, I'm not convinced this is something we need or want. You can evaluate emacs lisp blocks and you can use edit-special buffers to evaluate individual lines in a source block. Being able to execute arbitrary lisp forms at a top level inside an org buffer could be considered dangerous. I don't think it should be enabled by default.=20 >> As this is a breaking change, it should not be on by default. > Currently eval-defun errors out, and fixing that will break things > sooner or later, I think. > > I do not mind updating the patch to set the new option to nil by > default, although I'll wait for a second opinion on this. > That is fine. However, note that this would mean your patch can only be applied to the next version (development version) of org and not to the current maintenance branch because you cannot add a breaking change to an already released version. I think you are making it harder to get the patch applied by enabling the option. There is a (rightly) conservative stance on breaking changes. Adding a new option which is enabled by default and which breaks existing functionality has almost no chance of being applied. Adding a new option which is a breaking change that needs to be enabled by the user is far more likely to be considered.