emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Samim Pezeshki <p.samim@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table
Date: Fri, 21 Jan 2022 11:28:34 +0100	[thread overview]
Message-ID: <875yqdtmb1.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAJAdVc06_tj58Je=tn42JqfUtkjamQBQdcvobQXeegARS_M0hQ@mail.gmail.com> (Samim Pezeshki's message of "Mon, 10 Jan 2022 12:56:49 +0330")

Hello,

Samim Pezeshki <p.samim@gmail.com> writes:

> +(defcustom org-agenda-clock-report-header nil
> +  "Header for org agenda clock report mode"
> +  :group 'org-agenda
> +  :type 'string)

Please add :package-version and :safe keywords to the definition.

Also, type does not match the default value. You probably mean

(choice
 (string :tag "Header")
 (const :tag "No header" nil))

> +
>  (defun org-agenda-time-of-day-to-ampm (time)
>    "Convert TIME of a string like \"13:45\" to an AM/PM style time string."
>    (let* ((hour-number (string-to-number (substring time 0 -3)))
> @@ -4473,6 +4478,10 @@ items if they have an hour specification like [h]h:mm."
>  	  (setq p (plist-put p :tend clocktable-end))
>  	  (setq p (plist-put p :scope 'agenda))
>  	  (setq tbl (apply #'org-clock-get-clocktable p))
> +    (when org-agenda-clock-report-header
> +      (put-text-property 0 (length org-agenda-clock-report-header) 'face 'org-agenda-structure
> +                         org-agenda-clock-report-header)
> +      (insert org-agenda-clock-report-header))

Maybe:

  (insert (propertize org-agenda-clock-report-header 'face 'org-agenda-structure))

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou


  parent reply	other threads:[~2022-01-21 10:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-10  9:26 Samim Pezeshki
2022-01-10 10:27 ` Christopher M. Miles
2022-01-21  9:13   ` Samim Pezeshki
2022-01-21 10:28 ` Nicolas Goaziou [this message]
2022-01-22 16:24   ` Samim Pezeshki
2022-01-26 20:08     ` Nicolas Goaziou
2022-01-28  9:01     ` [ISSUE] " Christopher M. Miles
2022-05-09 12:38       ` [PATCH] " Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875yqdtmb1.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=p.samim@gmail.com \
    --subject='Re: [PATCH] lisp/org-agenda.el: Add header to agenda clock report table' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).