From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id QIXKGrfzI2OtdwEAbAwnHQ (envelope-from ) for ; Fri, 16 Sep 2022 05:55:35 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +H3oGbfzI2MYdQAAG6o9tA (envelope-from ) for ; Fri, 16 Sep 2022 05:55:35 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 068012B031 for ; Fri, 16 Sep 2022 05:55:34 +0200 (CEST) Received: from localhost ([::1]:49390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ2Rx-0004KR-8j for larch@yhetil.org; Thu, 15 Sep 2022 23:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ2RH-0004KI-TC for emacs-orgmode@gnu.org; Thu, 15 Sep 2022 23:54:51 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:37507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ2RG-0003jX-7B; Thu, 15 Sep 2022 23:54:51 -0400 Received: by mail-pl1-x636.google.com with SMTP id s18so14312191plr.4; Thu, 15 Sep 2022 20:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date; bh=HxbyQCFwG5sDWBNa66D3VHQ1VvTwgmQA1yT0uNbhgJ4=; b=CyZSj3LxuOdbTV+7lFNydVWSceExXl+XP/KzFVjj7Xzju2IKHxUrfWbiOCguhlWL7t wF65uE2k4x1cL+LDPpHmNEjeSQp9X0orwrmWCOwHIIOGu8H/5u1D9AV4OXDg44MOjGXW BsaTSpsqpp0vOMeboFc0qrWBSKXJIb1f+kwHwPhGxXfCXIlsC0eA6USJEirJ32eVjQsN AYI1xdSek6TbexbdbXShOMYmwj/WfN1dM2R2fYkMNzVeKhftxLC3/u/l1IdFIFIEpadk pUyeo/Tjv5I+FqMLvCk6C9MpOH+CVcDhGz53A5MiErFE2JEOB5GxlKka5gIV4d+Elgj1 8tzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date; bh=HxbyQCFwG5sDWBNa66D3VHQ1VvTwgmQA1yT0uNbhgJ4=; b=2wQicM6c6nIGaEdnZM07kLlpjmi0qAs4rCYNcHGi2eyAWHiFBOQXTSE5B/g8ZGnBYR h0jcBj3UMGh7SRlWQBI6G5Gw5cmo3dNsGXxFF1lPGZnl7vTrn7c1y7Oj6G/sTJIEbJCg jDwxSDn73wr9b2xiS6wYuH54IjrVUyj65nrw8aGzEpX5zxhZnP9H2gKVe0A2DzOZcpIh BisXBRI/0WQ4O7qc2LqlbhPytLJfUxWgU9eF+XGnzE3wg71JqGDRv7vv16bbfa4Tb2M8 mlNoU5BKHnhmdoCQ2ZbUXV6SzyMf83/6fGyFUawSL6RzOSbqd97sdYz1lbpaJcVOD+y1 /BTA== X-Gm-Message-State: ACrzQf2tedSWJSO2kHuaiq9sG5FXc8+Crne+tgmE7jo0kJAtCM9XwpxH 2P3DrzxFKDprqU5LcfI8LI8= X-Google-Smtp-Source: AMsMyM5RexFJ3bMdOhvae0AJdpmxTadNjjrO2Aj/FdRiuXPwWyEBy3X/Q6Nvr4AirMd2UfQmLgi+lg== X-Received: by 2002:a17:902:d58d:b0:176:da94:e6f7 with SMTP id k13-20020a170902d58d00b00176da94e6f7mr2682629plh.11.1663300488166; Thu, 15 Sep 2022 20:54:48 -0700 (PDT) Received: from localhost ([1.83.155.65]) by smtp.gmail.com with ESMTPSA id r2-20020aa79882000000b00536aa488062sm13367630pfl.163.2022.09.15.20.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 20:54:47 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin , Bastien Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ol.el: Always prompt for description in `org-insert-link' In-Reply-To: References: Date: Fri, 16 Sep 2022 11:55:44 +0800 Message-ID: <875yhoug5b.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=yantar92@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663300535; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HxbyQCFwG5sDWBNa66D3VHQ1VvTwgmQA1yT0uNbhgJ4=; b=lbKmG6wzwTuD2Vxlp841ElvbIthG3pZKssUNPyhjCrrl2ySjbDU12xUdmV7xqnqVxKWju/ 3Ay01b86S+4lJZou2wkMopTESa0S7YOEWjTGY7mVfcsiS/B7HMLsQBJ6+wVp/0sJUVbl3Q FTB5qeSEnarU/BLvHT7mvUFDO9CGI15NeD3byMeZjp5j+Qy/o3Ibl2a/n5sHBWjdvZ3xKs qEH2lxlwOayc2SaGogXxsMrO85/YByRzOtBN/++DxlFONJu4TGsw9JwqFiEle1ECebJdjO PVeY1Pb0WJFczyrch/cKMXdzXxbZRmfrCf/GQs0TkNHp7fMZD1pfzyXy17FUTg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663300535; a=rsa-sha256; cv=none; b=QFCoIfZEWJXNWrcauzxi6J5b6x3rLO2uLnheHy2PC9+SSiFdMxb8KXvzs/nuRz8If+qkbN kS5bBsebZsVw4tZ/svYnw/QjEuDTP/o8dxuzMPdFPrZjwHdUTcSaxak6Cadf2l/6amB/zk wHQWTlDp/S8UYEnoW8F9ZLMUc/TkTZ2wjo0i9lDdqvuk5Rdkuw+exBuhdczTrZfH8tCjRJ oDCyvV8gZaSgaly1FXHpaZGQTMICkjEB627ZhIzebu8Bslnm3A/ohr3QIPbFWx3MF2+CcW NEjz2unPjkAbb5vPJ6nKekQD4b0GwMQx3R2Q6eXnrrT26NISTnpYfjLzIZDJeQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CyZSj3Lx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=CyZSj3Lx; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 068012B031 X-Spam-Score: -1.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: BO2a6oV5hJdS Max Nikulin writes: > I have an idea how to fix the code to bypass the description prompt if > path is completed by description discarding identical path and > description, but I prefer to drop the confusing variable and not depend > on the means how the link was selected from the list of stored items. > > Have I missed something and unconditional prompt to edit link > description may be undesired in some cases? AFAIU, this particular behaviour is undocumented. If it is used by some other code, let's make tests for it, document, and fix in a better, more explicit way. I am unaware about the code using this link==description behaviour. Applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=69b36beac790bad95fdd9ce4a7bcfbbb46d39c64 https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d8d7fba61652434764c9906df69db373ff4f7f6 Bastien, Could you please check the ongoing changes in this area (storing/inserting links)? The code in this area is old, confusing, and not fully documented. I'm afraid that we may break something in the process of refactoring. If you see some dangerous changes, please let us know. -- Ihor Radchenko, Org mode contributor, Learn more about Org mode at https://orgmode.org/. Support Org development at https://liberapay.com/org-mode, or support my work at https://liberapay.com/yantar92